8000 fix: Forced variation not available in experiment by ozayr-zaviar · Pull Request #367 · optimizely/python-sdk · GitHub
[go: up one dir, main page]
Skip to content

fix: Forced variation not available in experiment #367

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Dec 22, 2021
Merged

fix: Forced variation not available in experiment #367

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
6d5f174
init
ozayr-zaviar Dec 13, 2021
e3af562
conditions fixed
ozayr-zaviar Dec 13, 2021
e480d8d
unit test added for no active experiment in create impression event
ozayr-zaviar Dec 14, 2021
9eed3ec
Apply suggestions from code review
msohailhussain Dec 14, 2021
fd0011c
Merge branch 'master' into uzair/fsc-case-fix
msohailhussain Dec 14, 2021
15ca2c6
linting fixed
ozayr-zaviar Dec 15, 2021
2f50072
comments addressed
ozayr-zaviar Dec 15, 2021
06addb3
test cases fix
ozayr-zaviar Dec 21, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Apply suggestions from code review 
Co-authored-by: Jae Kim <45045038+jaeopt@users.noreply.github.com>
  • Loading branch information
@msohailhussain @jaeopt
msohailhussain and jaeopt authored Dec 14, 2021
commit 9eed3ecbf557ecb486477985141d624b21b98cba
4 changes: 2 additions & 2 deletions optimizely/event/user_event_factory.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,8 +51,8 @@ def create_impression_event(

if variation_id and flag_key:
variation = project_config.get_flag_variation(flag_key, 'id', variation_id)
if not variation and variation_id and experiment_id:
# need this condition when we send events involving forced decisions
elif variation_id and experiment_id:
# need this condition when we send events involving forced decisions (F-to-D or E-to-D with any ruleKey/variationKey combinations)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Move this comment line to the top of line 52.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we have a unit test covering this bug?

variation = project_config.get_variation_from_id_by_experiment_id(experiment_id, variation_id)

event_context = user_event.EventContext(
Expand Down
0