-
Notifications
You must be signed in to change notification settings - Fork 83
feat: Add ODP GraphQL AP Interface #778
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Suggested a few changes. I assume fetch
should work in all environments but it will be great if you can check it once for browser, node and react native.
packages/optimizely-sdk/lib/plugins/odp/query_segments_parameters.ts
Outdated
Show resolved
Hide resolved
packages/optimizely-sdk/lib/plugins/odp/query_segments_parameters.ts
Outdated
Show resolved
Hide resolved
packages/optimizely-sdk/lib/plugins/odp/query_segments_parameters.ts
Outdated
Show resolved
Hide resolved
packages/optimizely-sdk/lib/plugins/odp/query_segments_parameters.ts
Outdated
Show resolved
Hide resolved
packages/optimizely-sdk/lib/utils/json_schema_validator/index.ts
Outdated
Show resolved
Hide resolved
I need to mock up the RequestHandlers
This reverts commit ef8dc52.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks Great! Just added a few suggestions.
packages/optimizely-sdk/lib/plugins/odp/query_segments_parameters.ts
Outdated
Show resolved
Hide resolved
packages/optimizely-sdk/lib/utils/http_request_handler/browser_request_handler.ts
Show resolved
Hide resolved
packages/optimizely-sdk/lib/utils/http_request_handler/request_handler_factory.ts
Outdated
Show resolved
Hide resolved
Co-authored-by: Zeeshan Ashraf <35262377+zashraf1985@users.noreply.github.com>
Co-authored-by: Zeeshan Ashraf <35262377+zashraf1985@users.noreply.github.com>
…ers.ts Co-authored-by: Zeeshan Ashraf <35262377+zashraf1985@users.noreply.github.com>
Summary
Add plugin to provide an internal service for ODP GraphQL server access. Should support 3 potential clients for Browser, Node, ReactNative
Test plan
New .spec. files added unit tests
Issues
OASIS-8409