8000 Remove throwError · optimizely/javascript-sdk@b4ed7bd · GitHub
[go: up one dir, main page]
Skip to content 8000

Commit b4ed7bd

Browse files
mikechu-optimizelymikechu-optimizely
committed
Remove throwError
1 parent 8308a53 commit b4ed7bd

File tree

5 files changed

+7
-16
lines changed

5 files changed

+7
-16
lines changed

‎packages/optimizely-sdk/lib/plugins/odp/graphql_manager.ts

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,6 @@ import { IOdpClient, OdpClient } from './odp_client';
2020
import { validate } from '../../utils/json_schema_validator';
2121
import { OdpResponseSchema } from './odp_response_schema';
2222
import { QuerySegmentsParameters } from './query_segments_parameters';
23-
import { throwError } from '../../utils/fns';
2423
import { RequestHandlerFactory } from '../../utils/http_request_handler/request_handler_factory';
2524

2625
/**
@@ -58,8 +57,8 @@ export class GraphqlManager implements IGraphQLManager {
5857
* @param client Client to use to send queries to ODP
5958
*/
6059
constructor(errorHandler: ErrorHandler, logger: LogHandler, client?: IOdpClient) {
61-
this._errorHandler = errorHandler ?? throwError('Error Handler is required');
62-
this._logger = logger ?? throwError('Logger is required');
60+
this._errorHandler = errorHandler;
61+
this._logger = logger;
6362

6463
this._odpClient = client ?? new OdpClient(this._errorHandler,
6564
this._logger,

‎packages/optimizely-sdk/lib/plugins/odp/odp_client.ts

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,6 @@ import { ErrorHandler, LogHandler, LogLevel } from '../../modules/logging';
1818
import { QuerySegmentsParameters } from './query_segments_parameters';
1919
import { RequestHandler, Response } from '../../utils/http_request_handler/http';
2020
import { REQUEST_TIMEOUT_MS } from '../../utils/http_request_handler/config';
21-
import { throwError } from '../../utils/fns';
2221

2322
/**
2423
* Standard failure message for fetch errors
@@ -53,9 +52,9 @@ export class OdpClient implements IOdpClient {
5352
* @param timeout Maximum milliseconds before requests are considered timed out
5453
*/
5554
constructor(errorHandler: ErrorHandler, logger: LogHandler, requestHandler: RequestHandler, timeout: number = REQUEST_TIMEOUT_MS) {
56-
this._errorHandler = errorHandler ?? throwError('Error Handler is required');
57-
this._logger = logger ?? throwError('Logger is required');
58-
this._requestHandler = requestHandler ?? throwError('Implementation of RequestHandler is required');
55+
this._errorHandler = errorHandler;
56+
this._logger = logger;
57+
this._requestHandler = requestHandler;
5958
this._timeout = timeout;
6059
}
6160

‎packages/optimizely-sdk/lib/utils/fns/index.ts

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -153,10 +153,6 @@ export function sprintf(format: string, ...args: any[]): string {
153153
})
154154
}
155155

156-
export function throwError(errorMessage: string): never {
157-
throw new Error(errorMessage);
158-
}
159-
160156
export default {
161157
assign,
162158
currentTimestamp,
@@ -172,5 +168,4 @@ export default {
172168
find,
173169
keyByUtil,
174170
sprintf,
175-
throwExpression: throwError,
176171
};

‎packages/optimizely-sdk/lib/utils/http_request_handler/browser_request_handler.ts

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,6 @@
1717
import { AbortableRequest, Headers, RequestHandler, Response } from './http';
1818
import { REQUEST_TIMEOUT_MS } from './config';
1919
import { LogHandler, LogLevel } from '../../modules/logging';
20-
import { throwError } from '../fns';
2120

2221
const READY_STATE_DONE = 4;
2322

@@ -29,7 +28,7 @@ export class BrowserRequestHandler implements RequestHandler {
2928
private readonly _timeout: number;
3029

3130
public constructor(logger: LogHandler, timeout: number = REQUEST_TIMEOUT_MS) {
32-
this._logger = logger ?? throwError('Logger is required.');
31+
this._logger = logger;
3332
this._timeout = timeout;
3433
}
3534

‎packages/optimizely-sdk/lib/utils/http_request_handler/node_request_handler.ts

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,6 @@ import { AbortableRequest, Headers, RequestHandler, Response } from './http';
2121
import { REQUEST_TIMEOUT_MS } from './config';
2222
import decompressResponse from 'decompress-response';
2323
import { LogHandler } from '../../modules/logging';
24-
import { throwError } from '../fns';
2524

2625
/**
2726
* Handles sending requests and receiving responses over HTTP via NodeJS http module
@@ -31,7 +30,7 @@ export class NodeRequestHandler implements RequestHandler {
3130
private readonly _timeout: number;
3231

3332
public constructor(logger: LogHandler, timeout: number = REQUEST_TIMEOUT_MS) {
34-
this._logger = logger ?? throwError('Logger is required.');
33+
this._logger = logger;
3534
this._timeout = timeout;
3635
}
3736

0 commit comments

Comments
 (0)
0