8000 [FSSDK-9076] fix: send odp event empty values by mnoman09 · Pull Request #513 · optimizely/java-sdk · GitHub
[go: up one dir, main page]
Skip to content

[FSSDK-9076] fix: send odp event empty values #513

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 25, 2023
Merged

[FSSDK-9076] fix: send odp event empty values #513

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e6fdf0c
[FSSDK-9076] fix: send odp event empty values
NomanShoaib Apr 20, 2023
e966e21
nit fix
NomanShoaib Apr 20, 2023
44fa6f8
Merge branch 'master' into mnoman/FSSDK-9076
NomanShoaib Apr 25, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
nit fix
  • Loading branch information
@NomanShoaib
NomanShoaib committed Apr 20, 2023
commit e966e21f776bef1be7724d194da7193530ba47df
3 changes: 1 addition & 2 deletions core-api/src/main/java/com/optimizely/ab/Optimizely.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1479,8 +1479,7 @@ public ODPManager getODPManager() {
*/
public void sendODPEvent(@Nullable String type, @Nonnull String action, @Nullable Map<String, String> identifiers, @Nullable Map<String, Object> data) {
if (odpManager != null) {
if (action == null || action.trim().isEmpty())
{
if (action == null || action.trim().isEmpty()) {
logger.error("ODP action is not valid (cannot be empty).");
return;
}
Expand Down
0