8000 [FSSDK-9076] fix: send odp event empty values by mnoman09 · Pull Request #513 · optimizely/java-sdk · GitHub
[go: up one dir, main page]
Skip to content

[FSSDK-9076] fix: send odp event empty values #513

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 25, 2023
Merged

[FSSDK-9076] fix: send odp event empty values #513

merged 3 commits into from
Apr 25, 2023

Conversation

mnoman09
Copy link
Contributor

Summary

  • Validate sendOdpEvent empty action and type parameters
  • Generate new idempotence_id for every OdpEvent

Test plan

added tests and all tests should pass.

Ticket

FSSDK-9076

@mnoman09 mnoman09 requested a review from a team as a code owner April 20, 2023 03:37
jaeopt
jaeopt approved these changes Apr 20, 2023
View reviewed changes
Copy link
Contributor
@jaeopt jaeopt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@NomanShoaib
Merge branch 'master' into mnoman/FSSDK-9076
44fa6f8 
# Conflicts:
#	core-api/src/main/java/com/optimizely/ab/odp/ODPEventManager.java
@mnoman09 mnoman09 merged commit 8dc9a74 into master Apr 25, 2023
@mnoman09 mnoman09 deleted the mnoman/FSSDK-9076 branch April 25, 2023 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaeopt jaeopt jaeopt approved these 53F0 changes

Assignees

@mnoman09 mnoman09

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mnoman09 @jaeopt @NomanShoaib
0