8000 Fix: Added notificationRegistry to make sure that odpSettings updates by mnoman09 · Pull Request #501 · optimizely/java-sdk · GitHub
[go: up one dir, main page]
Skip to content

Fix: Added notificationRegistry to make sure that odpSettings updates #501

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 20 commits into from
Jan 26, 2023
Merged

Fix: Added notificationRegistry to make sure that odpSettings updates #501

Changes from 1 commit
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
a006cf0
Added notificationRegistry to make sure that odpSettings update will …
NomanShoaib Jan 11, 2023
ed2bcbb
Updated headers and added additional checks in unittests
NomanShoaib Jan 11, 2023
51357cf
Added suppress warning
NomanShoaib Jan 11, 2023
f1c3d7a
renamed NoficationRegistry function.
NomanShoaib Jan 12, 2023
5d791f2
reverting header change
NomanShoaib Jan 12, 2023
01fd113
reverting extra changes
NomanShoaib Jan 12, 2023
9c4f729
reverting extra changes
NomanShoaib Jan 12, 2023
92004cf
nit fix
NomanShoaib Jan 12, 2023
01313a4
nit
NomanShoaib Jan 12, 2023
ecb12b5
Resolved comments
NomanShoaib Jan 16, 2023
38d735a
Added getCachedconfig Function to return ProjectConfig without wait, …
NomanShoaib Jan 18, 2023
0deec47
ProjectConfig getCachedConfig(); without default implementation
NomanShoaib Jan 18, 2023
e6bbc30
Merge branch 'master' into mnoman/addNotificationRegistry
NomanShoaib Jan 18, 2023
43da46a
Removed default implementation of getSDKkey to enforce user to make t…
NomanShoaib Jan 19, 2023
0fe4fb3
Resolved comments
NomanShoaib Jan 25, 2023
dd6a823
setting Sdk key inside pollingConfigManager to make sure that the sdk…
NomanShoaib Jan 25, 2023
680a5bf
setting sdkKey in parent class
NomanShoaib Jan 25, 2023
65c150d
fix
NomanShoaib Jan 25, 2023
5bc8ffd
making sure that if the SDKKey is set by the user then it should be p…
NomanShoa 8000 ib Jan 25, 2023
26d50ae
Refactored and moved getSdkKey to pollingConfigManager to make sure t…
NomanShoaib Jan 25, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Added suppress warning
  • Loading branch information
@NomanShoaib
NomanShoaib committed Jan 11, 2023
commit 51357cf8841f6aaa064e34fd4776ecc75fb5d66a
4 changes: 4 additions & 0 deletions core-api/src/test/java/com/optimizely/ab/internal/NotificationRegistryTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,13 +17,16 @@
package com.optimizely.ab.internal;

import com.optimizely.ab.notification.NotificationCenter;
import edu.umd.cs.findbugs.annotations.SuppressFBWarnings;
import org.junit.Assert;
import org.junit.Test;

import static org.junit.Assert.assertEquals;


public class NotificationRegistryTest {

@SuppressFBWarnings("NP_NONNULL_PARAM_VIOLATION")
@Test
public void getSameNotificationcenterWhenSDKkeyIsNull() {
String sdkKey = null;
Expand All @@ -40,6 +43,7 @@ public void getSameNotificationcenterWhenSDKkeyIsSameButNotNull() {
assertEquals(notificationCenter1, notificationCenter2);
}

@SuppressFBWarnings("NP_NONNULL_PARAM_VIOLATION")
@Test
public void getSameNotificationcenterWhenSDKkeyIsNullAndAnotherIsEmpty() {
String sdkKey1 = "";
Expand Down
0