10000 Fix: Added notificationRegistry to make sure that odpSettings updates by mnoman09 · Pull Request #501 · optimizely/java-sdk · GitHub
[go: up one dir, main page]
Skip to content

Fix: Added notificationRegistry to make sure that odpSettings updates #501

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 20 commits into from
Jan 26, 2023
Merged

Fix: Added notificationRegistry to make sure that odpSettings updates #501

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
a006cf0
Added notificationRegistry to make sure that odpSettings update will …
NomanShoaib Jan 11, 2023
ed2bcbb
Updated headers and added additional checks in unittests
NomanShoaib Jan 11, 2023
51357cf
Added suppress warning
NomanShoaib Jan 11, 2023
f1c3d7a
renamed NoficationRegistry function.
NomanShoaib Jan 12, 2023
5d791f2
reverting header change
NomanShoaib Jan 12, 2023
01fd113
reverting extra changes
NomanShoaib Jan 12, 2023
9c4f729
reverting extra changes
NomanShoaib Jan 12, 2023
92004cf
nit fix
NomanShoaib Jan 12, 2023
01313a4
nit
NomanShoaib Jan 12, 2023
ecb12b5
Resolved comments
NomanShoaib Jan 16, 2023
38d735a
Added getCachedconfig Function to return ProjectConfig without wait, …
NomanShoaib Jan 18, 2023
0deec47
ProjectConfig getCachedConfig(); without default implementation
NomanShoaib Jan 18, 2023
e6bbc30
Merge branch 'master' into mnoman/addNotificationRegistry
NomanShoaib Jan 18, 2023
43da46a
Removed default implementation of getSDKkey to enforce user to make t…
NomanShoaib Jan 19, 2023
0fe4fb3
Resolved comments
NomanShoaib Jan 25, 2023
dd6a823
setting Sdk key inside pollingConfigManager to make sure that the sdk…
NomanShoaib Jan 25, 2023
680a5bf
setting sdkKey in parent class
NomanShoaib Jan 25, 2023
65c150d
fix
NomanShoaib Jan 25, 2023
5bc8ffd
making sure that if the SDKKey is set by the user then it should be p…
NomanShoaib Jan 25, 2023
26d50ae
Refactored and moved getSdkKey to pollingConfigManager to make sure t…
NomanShoaib Jan 25, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Refactored and moved getSdkKey to pollingConfigManager to make sure t… 
…hat to trigger the notification always user provided sdkKey will be prioritized
  • Loading branch information
@NomanShoaib
NomanShoaib committed Jan 25, 2023
commit 26d50ae26e0433451baa1c759b57f8d63f705f07
5 changes: 5 additions & 0 deletions core-api/src/main/java/com/optimizely/ab/config/PollingProjectConfigManager.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -169,6 +169,11 @@ public OptimizelyConfig getOptimizelyConfig() {
return currentOptimizelyConfig.get();
}

@Override
public String getSDKKey() {
return this.sdkKey;
}

public synchronized void start() {
if (started) {
logger.warn("Manager already started.");
Expand Down
13 changes: 2 additions & 11 deletions core-httpclient-impl/src/main/java/com/optimizely/ab/config/HttpProjectConfigManager.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,6 @@ public class HttpProjectConfigManager extends PollingProjectConfigManager {
private final URI uri;
private final String datafileAccessToken;
private String datafileLastModified;
private String sdkKey;

private HttpProjectConfigManager(long period,
TimeUnit timeUnit,
Expand All @@ -74,13 +73,11 @@ private HttpProjectConfigManager(long period,
String datafileAccessToken,
long blockingTimeoutPeriod,
TimeUnit blockingTimeoutUnit,
NotificationCenter notificationCenter,
String sdkKey) {
NotificationCenter notificationCenter) {
super(period, timeUnit, blockingTimeoutPeriod, blockingTimeoutUnit, notificationCenter);
this.httpClient = httpClient;
this.uri = URI.create(url);
this.datafileAccessToken = datafileAccessToken;
this.sdkKey = sdkKey;
}

public URI getUri() {
Expand Down Expand Up @@ -170,11 +167,6 @@ public static Builder builder() {
return new Builder();
}

@Override
public String getSDKKey() {
return this.sdkKey;
}

public static class Builder {
private String datafile;
private String url;
Expand Down Expand Up @@ -364,8 +356,7 @@ public HttpProjectConfigManager build(boolean defer) {
datafileAccessToken,
blockingTimeoutPeriod,
blockingTimeoutUnit,
notificationCenter,
sdkKey);
notificationCenter);
httpProjectManager.setSdkKey(sdkKey);
if (datafile != null) {
try {
Expand Down
0