8000 [FSSDK-9001] Fix: ODP should be enabled by default when initialized optimizely using OptimizelyFactory by mnoman09 · Pull Request #337 · optimizely/csharp-sdk · GitHub
[go: up one dir, main page]
Skip to content

[FSSDK-9001] Fix: ODP should be enabled by default when initialized optimizely using OptimizelyFactory #337

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Mar 17, 2023
Merged

[FSSDK-9001] Fix: ODP should be enabled by default when initialized optimizely using OptimizelyFactory #337

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
3049bae
pushing demoapp
NomanShoaib Mar 10, 2023
771c625
using default odp manager when initializing optimizely using optimize…
NomanShoaib Mar 17, 2023
e677fe0
Revert "pushing demoapp"
NomanShoaib Mar 17, 2023
da1dafd
Added use odp check
NomanShoaib Mar 17, 2023
1b4f06c
Fix
NomanShoaib Mar 17, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
using default odp manager when initializing optimizely using optimize… 
…lyFactory to enable it by default
  • Loading branch information
@NomanShoaib
NomanShoaib committed Mar 17, 2023
commit 771c6254362e2b4a9b7a99afa3135f5afbd8439e
7 changes: 6 additions & 1 deletion OptimizelySDK/OptimizelyFactory.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@
using OptimizelySDK.Event.Dispatcher;
using OptimizelySDK.Logger;
using OptimizelySDK.Notifications;
using OptimizelySDK.Odp;

namespace OptimizelySDK
{
Expand Down Expand Up @@ -215,8 +216,12 @@ public static Optimizely NewDefaultInstance(ProjectConfigManager configManager,
UserProfileService userprofileService = null, EventProcessor eventProcessor = null
)
{
var odpManager = new OdpManager.Builder()
.WithErrorHandler(errorHandler)
.WithLogger(logger)
.Build();
return new Optimizely(configManager, notificationCenter, eventDispatcher, logger,
errorHandler, userprofileService, eventProcessor);
errorHandler, userprofileService, eventProcessor, null, odpManager);
}
}
}
0