8000 [FSSDK-9001] Fix: ODP should be enabled by default when initialized optimizely using OptimizelyFactory by mnoman09 · Pull Request #337 · optimizely/csharp-sdk · GitHub
[go: up one dir, main page]
Skip to content

[FSSDK-9001] Fix: ODP should be enabled by default when initialized optimizely using OptimizelyFactory #337

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Mar 17, 2023
Merged

[FSSDK-9001] Fix: ODP should be enabled by default when initialized optimizely using OptimizelyFactory #337

merged 5 commits into from
Mar 17, 2023

Conversation

mnoman09
Copy link
Contributor

Summary

  • Using default odp manager when initializing Optimizely instance using OptimizelyFactory. This will enable the odp by default.

Test plan

All tests should pass.

Issues

@mnoman09 mnoman09 requested a review from a team as a code owner March 17, 2023 10:12
mikechu-optimizely
mikechu-optimizely approved these changes Mar 17, 2023
View reviewed changes
Copy link
Contributor
@mikechu-optimizely mikechu-optimizely left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@mnoman09 mnoman09 merged commit c5592e7 into master Mar 17, 2023
@mnoman09 mnoman09 deleted the mnoman/FSSDK-9001 branch March 17, 2023 22:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikechu-optimizely mikechu-optimizely mikechu-optimizely approved these changes

Assignees

@mnoman09 mnoman09

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mnoman09 @mikechu-optimizely @NomanShoaib
0