Move readonlys into constructor

optimizely · mikechu-optimizely · Aug 17, 2022 · Aug 5, 2022 · Aug 5, 2022 · Aug 5, 2022
commit e042d994d5301a4457c54eac469cbcd3074c3c5a
diff --git a/OptimizelySDK/Odp/LruCache.cs b/OptimizelySDK/Odp/LruCache.cs
@@ -28,18 +28,20 @@ public class LruCache<T> : ICache<T>
         public const int DEFAULT_TIMEOUT_SECONDS = 600;
 
         private readonly ILogger _logger;
-        private readonly object _mutex = new object();
+        private readonly object _mutex;
         private readonly int _maxSize;
         private readonly long _timeoutMilliseconds;
-        private readonly OrderedDictionary _orderedDictionary = new OrderedDictionary();
+        private readonly OrderedDictionary _orderedDictionary;
 
         public LruCache(int maxSize = DEFAULT_MAX_SIZE,
             int timeoutSeconds = DEFAULT_TIMEOUT_SECONDS, ILogger logger = null
         )
         {
+            _mutex  = new object();
             _maxSize = Math.Max(0, maxSize);
             _timeoutMilliseconds = Math.Max(0, timeoutSeconds) * 1000L;
             _logger = logger ?? new DefaultLogger();
+            _orderedDictionary = new OrderedDictionary();
         }
 
         public void Save(string key, T value)