Readonly and remove excess methods/constructor

optimizely · mikechu-optimizely · Aug 17, 2022 · Aug 5, 2022 · Aug 5, 2022 · Aug 5, 2022
commit 9fe246e47268c99e6ac674fff1885fa867e68f79
diff --git a/OptimizelySDK/Odp/LruCache.cs b/OptimizelySDK/Odp/LruCache.cs
@@ -27,52 +27,19 @@ public class LruCache<T> : ILruCache<T>
 
         private readonly ILogger _logger;
         private readonly object _mutex = new object();
-        private int _maxSize;
-        private long _timeoutMilliseconds;
-        private OrderedDictionary _orderedDictionary = new OrderedDictionary();
+        private readonly int _maxSize;
+        private readonly long _timeoutMilliseconds;
+        private readonly OrderedDictionary _orderedDictionary = new OrderedDictionary();
 
         public LruCache() : this(DEFAULT_MAX_SIZE, DEFAULT_TIMEOUT_SECONDS, null) { }
 
-        public LruCache(ILogger logger) :
-            this(DEFAULT_MAX_SIZE, DEFAULT_TIMEOUT_SECONDS, logger) { }
-
-
         public LruCache(int maxSize, int timeoutSeconds, ILogger logger = null)
         {
             _maxSize = maxSize < 0 ? default : maxSize;
             _timeoutMilliseconds = (timeoutSeconds < 0) ? 0 : (timeoutSeconds * 1000L);
             _logger = logger ?? new DefaultLogger();
         }
 
-        public void SetMaxSize(int size)
-        {
-            lock (_mutex)
-            {
-                if (_orderedDictionary.Count > 0)
-                {
-                    if (size >= _orderedDictionary.Count)
-                    {
-                        _maxSize = size;
-                    }
-                    else
-                    {
-                        _logger.Log(LogLevel.WARN,
-                            "Cannot set max cache size less than current size.");
-                    }
-                }
-                else
-                {
-                    var sizeToSet = size;
-                    if (size < 0)
-                    {
-                        sizeToSet = 0;
-                    }
-
-                    _maxSize = sizeToSet;
-                }
-            }
-        }
-
         public void Save(string key, T value)
         {
             if (_maxSize == 0)