8000 fix: set client-engine version in events by jaeopt · Pull Request #410 · optimizely/android-sdk · GitHub
[go: up one dir, main page]
Skip to content

fix: set client-engine version in events #410

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 17 commits into from
Mar 28, 2022
Merged

fix: set client-engine version in events #410

Changes from 1 commit
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
3b4de14
clean up
jaeopt Mar 9, 2022
056f277
fix client-sdk name/version override
jaeopt Mar 15, 2022
20f10cd
fix copyright year
jaeopt Mar 15, 2022
59810bd
upgrade java-sdk to 3.10.2
jaeopt Mar 18, 2022
8fdcd7e
Merge branch 'master' into jae/event-version
jaeopt Mar 18, 2022
e36be44
log SDK version
jaeopt Mar 18, 2022
127d748
specify BuildConfig path
jaeopt Mar 18, 2022
064cbcf
add guard for CLIENT_VERSION
jaeopt Mar 22, 2022
5756668
testing
jaeopt Mar 22, 2022
1a03b71
testing
jaeopt Mar 22, 2022
556fef4
clean up
jaeopt Mar 23, 2022
c42f362
testing
jaeopt Mar 23, 2022
8eaa6d1
fix gradle to avoid undetermistic version in travis
jaeopt Mar 23, 2022
f348e83
testing
jaeopt Mar 23, 2022
ed4dda1
add null and empty check for client version in gradle
jaeopt Mar 24, 2022
a41fa3d
clean up
jaeopt Mar 24, 2022
238445a
Merge branch 'master' into jae/event-version
jaeopt Mar 24, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
testing
  • Loading branch information
@jaeopt
jaeopt committed Mar 23, 2022
commit c42f3620b2eb6c69c9f85c3b508f997c47ead292
5 changes: 4 additions & 1 deletion android-sdk/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,10 @@ android {
versionCode 1
versionName version_name
testInstrumentationRunner 'androidx.test.runner.AndroidJUnitRunner'
buildConfigField "String", "CLIENT_VERSION", "\"$version_name\""

// buildConfigField "String", "CLIENT_VERSION", "\"$version_name\""
buildConfigField "String", "CLIENT_VERSION", "\"1.2.3\""

// these rules will be merged to app's proguard rules
consumerProguardFiles '../proguard-rules.txt'
}
Expand Down
0