8000 fix: set client-engine version in events by jaeopt · Pull Request #410 · optimizely/android-sdk · GitHub
[go: up one dir, main page]

Skip to content

fix: set client-engine version in events #410

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 17 commits into from
Mar 28, 2022
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
clean up
  • Loading branch information
jaeopt committed Mar 23, 2022
commit 556fef4f4967a89d0070d7984ec0701daa589d4e
Original file line number Diff line number Diff line change
Expand Up @@ -62,8 +62,6 @@ public void eventClientNameAndVersion() throws Exception {
ArgumentCaptor<LogEvent> argument = ArgumentCaptor.forClass(LogEvent.class);
verify(mockEventHandler, timeout(5000)).dispatchEvent(argument.capture());
assertEquals(argument.getValue().getEventBatch().getClientName(), "android-sdk");

assertEquals(argument.getValue().getEventBatch().getClientVersion(), BuildConfig.LIBRARY_PACKAGE_NAME);
assertEquals(argument.getValue().getEventBatch().getClientVersion(), BuildConfig.CLIENT_VERSION);
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -125,7 +125,7 @@ public class OptimizelyManager {
this.defaultDecideOptions = defaultDecideOptions;

try {
sdkVersion = com.optimizely.ab.android.sdk.BuildConfig.CLIENT_VERSION;
sdkVersion = BuildConfig.CLIENT_VERSION;
logger.info("SDK Version: {}", sdkVersion);
} catch (Exception e) {
logger.warn("Error getting BuildConfig version");
Expand Down
0