10BC0 mysql: check for truncated buffers by mmat11 · Pull Request #593 · open-telemetry/opentelemetry-ebpf-instrumentation · GitHub
[go: up one dir, main page]
Skip to content

mysql: check for truncated buffers #593

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 11, 2025
Merged

mysql: check for truncated buffers #593

merged 1 commit into from
Sep 11, 2025

Conversation

mmat11
Copy link
Contributor
@mmat11 mmat11 commented Sep 11, 2025

Fixes

panic: runtime error: index out of range [3] with length 0
goroutine
10000
 337 [running]:
encoding/binary.littleEndian.Uint32(...)
/usr/local/go/src/encoding/binary/binary.go:91
go.opentelemetry.io/obi/pkg/components/sqlprune.mysqlParseStatementID(...)
/src/pkg/components/sqlprune/mysql.go:98
go.opentelemetry.io/obi/pkg/components/sqlprune.SQLParseStatementID(...)
/src/pkg/components/sqlprune/sqlparser.go:169
go.opentelemetry.io/obi/pkg/components/ebpf/common.handleMySQL(_, _, {_, _, _}, {_, _, _})
/src/pkg/components/ebpf/common/sql_detect_mysql.go:114 +0xbe6
go.opentelemetry.io/obi/pkg/components/ebpf/common.ReadTCPRequestIntoSpan(_, _, _, {_, _})
/src/pkg/components/ebpf/common/tcp_detect_transform.go:49 +0x555
go.opentelemetry.io/obi/pkg/components/ebpf/common.ReadBPFTraceAsSpan(_, _, _, {_, _})
/src/pkg/components/ebpf/common/common.go:229 +0x2db
go.opentelemetry.io/obi/pkg/components/ebpf/common.(*ringBufForwarder).processAndForward(0xc000d72480, {{0xc000dc38c0, 0x210, 0x210}, 0x7090}, 0xc000aca500)
/src/pkg/components/ebpf/common/ringbuf.go:184 +0x16f
go.opentelemetry.io/obi/pkg/components/ebpf/common.(*ringBufForwarder).readAndForwardInner(0xc000d72480, {0x2fb5a78?, 0xc000442b40?}, {0x2f9eef0, 0xc000d99ab0}, 0xc000aca500)
/src/pkg/components/ebpf/common/ringbuf.go:170 +0x1b1
go.opentelemetry.io/obi/pkg/components/ebpf/common.(*ringBufForwarder).sharedReadAndForward(0xc000d72480, {0x2fb5a78, 0xc000442b40}, {0xc000c66008, 0xee, 0x12f}, 0xc000aca500)
/src/pkg/components/ebpf/common/ringbuf.go:116 +0x259
go.opentelemetry.io/obi/pkg/components/ebpf/generictracer.(*Tracer).Run(0xc000c12008, {0x2fb5a78, 0xc000442b40}, 0xc000da87c0, 0xc000aca500)
/src/pkg/components/ebpf/generictracer/generictracer.go:478 +0x491
go.opentelemetry.io/obi/pkg/components/ebpf.(*ProcessTracer).Run.func1()
/src/pkg/components/ebpf/tracer_linux.go:143 +0x75
created by go.opentelemetry.io/obi/pkg/components/ebpf.(*ProcessTracer).Run in goroutine 288
/src/pkg/components/ebpf/tracer_linux.go:141 +0x1ee

@mmat11
mysql: check for truncated buffers
c0e0180 
Signed-off-by: Mattia Meleleo <mattia.meleleo@coralogix.com>
@mmat11 mmat11 requested a review from a team as a code owner September 11, 2025 12:35
@codecov Codecov
Copy link
codecov bot commented Sep 11, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 61.12%. Comparing base (5f63322) to head (c0e0180).
⚠️ Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
pkg/components/sqlprune/mysql.go 0.00% 5 Missing ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #593   +/-   ##
=======================================
  Coverage   61.11%   61.12%           
=======================================
  Files         199      199           
  Lines       21901    21902    +1     
=======================================
+ Hits        13385    13387    +2     
+ Misses       7578     7577    -1     
  Partials      938      938
Flag Coverage Δ
integration-test-arm 33.59% <0.00%> (+0.03%) ⬆️
k8s-integration-test-1738- ?
k8s-integration-test-1745- 49.79% <0.00%> (?)
oats-test 36.43% <0.00%> (+0.16%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

grcevski
grcevski approved these changes Sep 11, 2025
View reviewed changes
Copy link
Contributor
@grcevski grcevski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! thanks!

@grcevski grcevski merged commit 93fcaa5 into open-telemetry:main Sep 11, 2025
19 checks passed
rafaelroquetto pushed a commit to grafana/opentelemetry-ebpf-instrumentation that referenced this pull request Sep 11, 2025
@mmat11 @rafaelroquetto
mysql: check for truncated buffers (open-telemetry#593)
ae55e08
@rafaelroquetto rafaelroquetto mentioned this pull request Sep 11, 2025
Merged
rafaelroquetto added a commit to grafana/beyla that referenced this pull request Sep 11, 2025
@rafaelroquetto
Prepare release 2.6.4 (#2188)
cb0a849 
- Fix crash in cluster_url: open-telemetry/opentelemetry-ebpf-instrumentation#597
- Allow ExportModes to be pragmatically constructed: open-telemetry/opentelemetry-ebpf-instrumentation#590
- mysql: check for truncated buffers: open-telemetry/opentelemetry-ebpf-instrumentation#593
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grcevski grcevski grcevski approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mmat11 @grcevski
0