E545 Allow ExportModes to be pragmatically constructed by rafaelroquetto · Pull Request #590 · open-telemetry/opentelemetry-ebpf-instrumentation · GitHub
[go: up one dir, main page]

Skip to content

Conversation

rafaelroquetto
Copy link
Contributor

At the moment the only way to construct a non-unset object is via YAML unmarshalling. This lets us construct it pragmatically - used in downstream projects.

@rafaelroquetto rafaelroquetto requested a review from a team as a code owner September 11, 2025 01:52
Copy link
codecov bot commented Sep 11, 2025

Codecov Report

❌ Patch coverage is 0% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 60.91%. Comparing base (5f63322) to head (2066cdc).
⚠️ Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
pkg/services/export.go 0.00% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #590      +/-   ##
==========================================
- Coverage   61.11%   60.91%   -0.20%     
==========================================
  Files         199      199              
  Lines       21901    21907       +6     
==========================================
- Hits        13385    13345      -40     
- Misses       7578     7615      +37     
- Partials      938      947       +9     
Flag Coverage Δ
integration-test-arm 33.49% <0.00%> (-0.06%) ⬇️
k8s-integration-test-1738- ?
k8s-integration-test-1743- 49.78% <0.00%> (?)
oats-test 36.28% <0.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor
@grcevski grcevski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@grcevski grcevski merged commit b9499fc into open-telemetry:main Sep 11, 2025
19 checks passed
@rafaelroquetto rafaelroquetto deleted the update_exportmodes branch September 11, 2025 17:00
rafaelroquetto added a commit to grafana/opentelemetry-ebpf-instrumentation that referenced this pull request Sep 11, 2025
rafaelroquetto added a commit to grafana/beyla that referenced this pull request Sep 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0