[FW][FIX] account: fallback to correct move link in bank matching #210492
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When reconciling an invoice and payment in foreign currency on different dates, an exchange rate difference line is added. This results in more than one value in `reconciled_lines_ids`, and `moveData()` no longer resolves a link to the move, so the bank statement is shown instead. This commit introduces a non-stored computed field to filter out exchange difference lines from `reconciled_lines_ids`. The kanban now uses this filtered field as a fallback when the reconciled lines are ambiguous. Steps to reproduce: 1. Enable a foreign currency and create two rates on different dates. 2. Create an invoice on one of the dates and a transaction to pay it on the other. 3. Reconcile them. task-4749264 X-original-commit: 4147760
|
|
|
@alialfie @malb-odoo this PR targets master and is the last of the forward-port chain. To merge the full chain, use
More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port |
|
@robodoo r+ |
robodoo
pushed a commit
that referenced
this pull request
May 17, 2025
When reconciling an invoice and payment in foreign currency on different dates, an exchange rate difference line is added. This results in more than one value in `reconciled_lines_ids`, and `moveData()` no longer resolves a link to the move, so the bank statement is shown instead. This commit introduces a non-stored computed field to filter out exchange difference lines from `reconciled_lines_ids`. The kanban now uses this filtered field as a fallback when the reconciled lines are ambiguous. Steps to reproduce: 1. Enable a foreign currency and create two rates on different dates. 2. Create an invoice on one of the dates and a transaction to pay it on the other. 3. Reconcile them. task-4749264 closes #210492 X-original-commit: 4147760 Related: odoo/enterprise#85819 Signed-off-by: Maximilien La Barre (malb) <malb@odoo.com>
AhmedElemary57
pushed a commit
to odoo-dev/odoo
that referenced
this pull request
May 18, 2025
When reconciling an invoice and payment in foreign currency on different dates, an exchange rate difference line is added. This results in more than one value in `reconciled_lines_ids`, and `moveData()` no longer resolves a link to the move, so the bank statement is shown instead. This commit introduces a non-stored computed field to filter out exchange difference lines from `reconciled_lines_ids`. The kanban now uses this filtered field as a fallback when the reconciled lines are ambiguous. Steps to reproduce: 1. Enable a foreign currency and create two rates on different dates. 2. Create an invoice on one of the dates and a transaction to pay it on the other. 3. Reconcile them. task-4749264 closes odoo#210492 X-original-commit: 4147760 Related: odoo/enterprise#85819 Signed-off-by: Maximilien La Barre (malb) <malb@odoo.com>
fdardenne
pushed a commit
to odoo-dev/odoo
that referenced
this pull request
May 26, 2025
When reconciling an invoice and payment in foreign currency on different dates, an exchange rate difference line is added. This results in more than one value in `reconciled_lines_ids`, and `moveData()` no longer resolves a link to the move, so the bank statement is shown instead. This commit introduces a non-stored computed field to filter out exchange difference lines from `reconciled_lines_ids`. The kanban now uses this filtered field as a fallback when the reconciled lines are ambiguous. Steps to reproduce: 1. Enable a foreign currency and create two rates on different dates. 2. Create an invoice on one of the dates and a transaction to pay it on the other. 3. Reconcile them. task-4749264 closes odoo#210492 X-original-commit: 4147760 Related: odoo/enterprise#85819 Signed-off-by: Maximilien La Barre (malb) <malb@odoo.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When reconciling an invoice and payment in foreign currency on different dates, an exchange rate difference line is added. This results in more than one value in
reconciled_lines_ids, andmoveData()no longer resolves a link to the move, so the bank statement is shown instead.This commit introduces a non-stored computed field to filter out exchange difference lines from
reconciled_lines_ids. The kanban now uses this filtered field as a fallback when the reconciled lines are ambiguous.Steps to reproduce:
task-4749264
Forward-Port-Of: #207968