[FIX] account: fallback to correct move link in bank matching #207968
+16
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
19bc91b to
6459ca4
Compare
6459ca4 to
e7e0176
Compare
malb-odoo
reviewed
May 6, 2025
e7e0176 to
7ac1d2b
Compare
34f0b7d to
734e928
Compare
When reconciling an invoice and payment in foreign currency on different dates, an exchange rate difference line is added. This results in more than one value in `reconciled_lines_ids`, and `moveData()` no longer resolves a link to the move, so the bank statement is shown instead. This commit introduces a non-stored computed field to filter out exchange difference lines from `reconciled_lines_ids`. The kanban now uses this filtered field as a fallback when the reconciled lines are ambiguous. Steps to reproduce: 1. Enable a foreign currency and create two rates on different dates. 2. Create an invoice on one of the dates and a transaction to pay it on the other. 3. Reconcile them. task-4749264
734e928 to
ff7bcf1
Compare
|
Upgrade exception #573 added. Waiting the forward-port of this PR, the exception will be applied on all builds, and create an inconsistent state for migrations. Important Please forward port this PR ASAP up to master without change, preferably before the end of the week. PRs adding fields/models should be merged at the beginning of the week and all the forward ports should be merged in the same week. If you need to apply any change before it reaches master, please notify runbot team. Details: |
|
@robodoo r+ |
|
@malb-odoo you may want to rebuild or fix this PR as it has failed CI. |
robodoo
pushed a commit
that referenced
this pull request
May 17, 2025
When reconciling an invoice and payment in foreign currency on different dates, an exchange rate difference line is added. This results in more than one value in `reconciled_lines_ids`, and `moveData()` no longer resolves a link to the move, so the bank statement is shown instead. This commit introduces a non-stored computed field to filter out exchange difference lines from `reconciled_lines_ids`. The kanban now uses this filtered field as a fallback when the reconciled lines are ambiguous. Steps to reproduce: 1. Enable a foreign currency and create two rates on different dates. 2. Create an invoice on one of the dates and a transaction to pay it on the other. 3. Reconcile them. task-4749264 closes #207968 Related: odoo/enterprise#84424 Signed-off-by: Maximilien La Barre (malb) <malb@odoo.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When reconciling an invoice and payment in foreign currency on different dates, an exchange rate difference line is added. This results in more than one value in
reconciled_lines_ids, andmoveData()no longer resolves a link to the move, so the bank statement is shown instead.This commit introduces a non-stored computed field to filter out exchange difference lines from
reconciled_lines_ids. The kanban now uses this filtered field as a fallback when the reconciled lines are ambiguous.Steps to reproduce:
task-4749264