8000 [IMP] l10n_id: 11/12 DPP Adjustment by kidoodoo · Pull Request #12732 · odoo/documentation · GitHub
[go: up one dir, main page]
Skip to content

[IMP] l10n_id: 11/12 DPP Adjustment #12732

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: 16.0
Choose a base branch
from
Open

[IMP] l10n_id: 11/12 DPP Adjustment #12732

wants to merge 1 commit into from

Conversation

kidoodoo
Copy link
Contributor
@kidoodoo kidoodoo commented Apr 1, 2025 •
edited
Loading

Following the 2025 tax base computation adjustment, small update to be made on the Indonesia localization documentation.
Soon, the proper update of Indonesia localization page is to be submitted.

task-4485693

@robodoo
Copy link
Collaborator
robodoo commented Apr 1, 2025

Pull request status dashboard

@kidoodoo kidoodoo marked this pull request as ready for review April 15, 2025 06:45
@C3POdoo C3POdoo requested a review from a team April 15, 2025 06:47
@afma-odoo afma-odoo requested review from afma-odoo and removed request for a team April 15, 2025 11:38
@afma-odoo
Copy link
Contributor

@kidoodoo Thank you for the update!
We're currently testing our new guidelines and templates for localization documentation pages. Would that suit you if I took the opportunity to apply those principles to the Indonesian page? If so, I'll go ahead and update it then force-push the changes. Then, I'll ask you to check if I didn't miss anything. Does that work for you?
Thank you!

@kidoodoo
Copy link
Contributor Author

@afma-odoo

Sure, that works on our side!

One on the side note is that soon, in a month or two, we will be submitting the overall update of Indonesia localization page since current information, screenshots are outdated with missing information.
For this PR, I submitted first since this is more of falling under urgent requirement due to recent changes in the regulation.

The task is under review at the moment so we still have sometime. I was just wondering if you would prefer to apply the guidelines now or wait for us to provide updated information.

All good on myside!

@afma-odoo
Copy link
Contributor

@kidoodoo Thanks for your explanation.
You're right, since it's a small update, I'll just do a quick review.
I'll share the guideline/template that you can use to structure the overall update of the Indonesia localization page. It should help you structure the page.
Feel free to reach out if you have any questions!

I'll let you know when I'm done with the DPP Adjustment review.

afma-odoo
afma-odoo requested changes Apr 17, 2025
View reviewed changes
Copy link
Contributor
@afma-odoo afma-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @kidoodoo for your work on the Indonesian page.
I added some comments/suggestions. Let me know if you have any questions!
Thank you ☺️

@kidoodoo
Copy link
Contributor Author
kidoodoo commented Apr 18, 2025 •
edited
Loading

Hello @afma-odoo !

Thank you so much for the review, I made the changes accordingly.

The above is the link for the runbot, the feature has not been merged yet, and it is waiting for its second review.
The PR can be found here for your reference.

At the moment, I would not expect additional changes to be made on the feature/documentation, but I submitted first to have the documentation ready considering the urgency of the feature. (Hopefully, this is okay. If this should not happen in the future, please feel free to let me know 🥹 )

Would it be okay for me to ping you once the feature is merged to r+ the following PR?

@kidoodoo @afma-odoo
[IMP] l10n_id: 11/12 DPP Adjustment
93d6fe5 
Following the 2025 tax base computation adjustment, small update to be made on the Indonesia localization documentation.

task-4485693
afma-odoo
afma-odoo approved these changes Apr 18, 2025
View reviewed changes
Copy link
Contributor
@afma-odoo afma-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @kidoodoo!
Thanks for the update and the explanation ☺️
Yes, of course, it's okay to submit the documentation first to make sure it's ready in time ;)

I just force-pushed some changes to fix minor typos.
I approve it and add the be-doc-review for the next step ;)
Since it's the be-doc-review team that usually r+ PRs, and to make sure the documentation is online once the feature is merged, they'll delegate the r+ to you once they approve the PR.
Let me know if you have any questions :)

@odoo/be-doc-review, can you delegate the r+ when you approve the PR so @kidoodoo can r+ only once the feature is merged? Thanks!

@afma-odoo afma-odoo requested a review from a team April 18, 2025 07:47
xpl-odoo
xpl-odoo approved these changes Apr 29, 2025
View reviewed changes
Copy link
Contributor
@xpl-odoo xpl-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@robodoo delegate+

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xpl-odoo xpl-odoo xpl-odoo approved these changes

@afma-odoo afma-odoo afma-odoo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kidoodoo @robodoo @afma-odoo @xpl-odoo
0