8000 BUG: missing comma disabled some header checks by juliantaylor · Pull Request #8694 · numpy/numpy · GitHub
[go: up one dir, main page]
Skip to content

BUG: missing comma disabled some header checks #8694

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 25, 2017
Merged

BUG: missing comma disabled some header checks #8694

merged 1 commit into from
Feb 25, 2017

Conversation

juliantaylor
Copy link
Contributor

closes gh-8693

@matthew-brett
Copy link
Contributor

Looks right to me. Fixes compilation on macOS.
8000

@juliantaylor
Copy link
Contributor Author

odd that HAVE_DLFCN_H is somehow defined on my machine despite the broken check, must be defined by the python header itself somehow.
added an explicit npy_config.h include due to "include what you use directly"

@juliantaylor juliantaylor merged commit 1717114 into numpy:master Feb 25, 2017
@juliantaylor juliantaylor deleted the mac-build branch February 25, 2017 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
00 - Bug component: numpy._core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

macOSX / clang compile fails with undefined locale identifiers
3 participants
@juliantaylor @matthew-brett @charris
0