8000 macOSX / clang compile fails with undefined locale identifiers · Issue #8693 · numpy/numpy · GitHub
[go: up one dir, main page]
Skip to content

macOSX / clang compile fails with undefined locale identifiers #8693

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
matthew-brett opened this issue Feb 25, 2017 · 2 comments · Fixed by #8694
Closed

macOSX / clang compile fails with undefined locale identifiers #8693

matthew-brett opened this issue Feb 25, 2017 · 2 comments · Fixed by #8694

Comments

@matthew-brett
Copy link
Contributor

macOSX build now failing with undefined locale identifiiers, after merge of #7997 :

clang: numpy/core/src/multiarray/numpyos.c
numpy/core/src/multiarray/numpyos.c:518:5: error: use of undeclared identifier 'locale_t'
    locale_t clocale;

https://travis-ci.org/MacPython/numpy-wheels/jobs/205229905#L3775

Errors result from merge of #7997 - commit 23ac855 builds (pre-merge), commit 7bc881d breaks (the merge commit).

@juliantaylor - any thoughts?
@juliantaylor
Copy link
Contributor

the pr doesn't have any changes that should cause this.
how is HAVE_STRTOLD_L in the config.h of the build folder defined in the working and not working commit? make sure to clean the build folder before each build

@juliantaylor
Copy link
Contributor

ah I see the problem, a missing comma ...

@juliantaylor juliantaylor mentioned this issue Feb 25, 2017
Merged
juliantaylor added a commit to juliantaylor/numpy that referenced this issue Feb 25, 2017
@juliantaylor
BUG: missing comma disabled some header checks
270927f 
closes numpygh-8693
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

BUG: missing comma disabled some header checks juliantaylor/numpy
2 participants
@matthew-brett @juliantaylor
0