BUG: npy_acosh fallback too simple. #6976
Conversation
|
LGTM. That's a pretty remarkable improvement for such a small change. |
|
Apparently none of our tests uses a sufficiently old glib to test this or we would already have seen the error, so not waiting on AppVeyor here. Thanks Eric. |
BUG: npy_acosh fallback too simple.
|
IIUC, instead of carrying around lots of ad hoc fallbacks like this, what Julia has done is put together their own known-good portable libm, which they just use everywhere: https://github.com/JuliaLang/openlibm Given that it exists and is already maintained by other people, it might be worth stealing for our own use too... |
|
@njsmith Several people have mentioned that. What might be interesting would be to make a separate math module with ufuncs that other projects could also use. That way scipy, for instance, could get improved math while supporting older numpy versions. |
|
I guess openlibm already is "a separate math module ... that other projects could also use", and the nice thing is that someone else is worrying about maintaining it :-). I'm not sure what you mean about ufuncs, though. |
|
I mean a numpy compatible Python module from which we, and others, could import ufuncs. |
|
So a new package that depends on numpy? I guess this sounds like a lot more On Fri, Jan 8, 2016 at 7:19 PM, Charles Harris notifications@github.com
Nathaniel J. Smith -- http://vorpus.org |
Fixes gh-6712.
Comparing the old implementation against mpmath with 1000 digits:
and the new implementation: