BUG: mask nan to 1 in ordered compare #6438
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@cgohlke: can you confirm that this works for you too? |
msvc2008 32 bit seems to miscompile it otherwise. closes numpygh-6428
a354899 to
fbf549b
Compare
|
@juliantaylor: well, I don't understand much from the code, so I'm sure it's fine but I guess I'll suggest that adding a comment might be good :-) |
|
@juliantaylor I'm going with the SSE2 solution, so going to close this. Thanks for working this problem under time pressure. |
|
I still think this is a reasonable change having a comparison including nan might be dodgy concerning floating point signals |
charris
added a commit
that referenced
this pull request
Oct 11, 2015
BUG: mask nan to 1 in ordered compare
|
OK, thanks Julian |
charris
added a commit
that referenced
this pull request
Oct 11, 2015
Backport gh-6438: BUG: mask nan to 1 in ordered compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
msvc2008 32 bit seems to miscompile it otherwise.
closes gh-6428