BUG: mask nan to 1 in ordered compare

juliantaylor · juliantaylor · commit fbf549b9c291 · 2015-10-10T00:43:33.000+02:00
msvc2008 32 bit seems to miscompile it otherwise. closes gh-6428
diff --git a/numpy/core/src/umath/simd.inc.src b/numpy/core/src/umath/simd.inc.src
@@ -536,11 +536,13 @@ sse2_compress4_to_byte_@TYPE@(@vtype@ r1, @vtype@ r2, @vtype@ r3, @vtype@ * r4,
 static NPY_INLINE int
 sse2_ordered_cmp_@kind@_@TYPE@(const @type@ a, const @type@ b)
 {
+    @vtype@ one = @vpre@_set1_@vsuf@(1);
     @type@ tmp;
     @vtype@ v = @vpre@_@VOP@_@vsufs@(@vpre@_load_@vsufs@(&a),
                                      @vpre@_load_@vsufs@(&b));
+    v = @vpre@_and_@vsuf@(v, one);
     @vpre@_store_@vsufs@(&tmp, v);
-    return !(tmp == 0.);
+    return tmp;
 }
 
 static void

Original file line number	Diff line number	Diff line change
`@@ -536,11 +536,13 @@ sse2_compress4_to_byte_@TYPE@(@vtype@ r1, @vtype@ r2, @vtype@ r3, @vtype@ * r4,`
`536`	`536`	`static NPY_INLINE int`
`537`	`537`	`sse2_ordered_cmp_@kind@_@TYPE@(const @type@ a, const @type@ b)`
`538`	`538`	`{`
	`539`	`+ @vtype@ one = @vpre@_set1_@vsuf@(1);`
`539`	`540`	`@type@ tmp;`
`540`	`541`	`@vtype@ v = @vpre@_@VOP@_@vsufs@(@vpre@_load_@vsufs@(&a),`
`541`	`542`	`@vpre@_load_@vsufs@(&b));`
	`543`	`+ v = @vpre@_and_@vsuf@(v, one);`
`542`	`544`	`@vpre@_store_@vsufs@(&tmp, v);`
`543`		`- return !(tmp == 0.);`
	`545`	`+ return tmp;`
`544`	`546`	`}`
`545`	`547`
`546`	`548`	`static void`