8000 BUG: Make np.nonzero threading safe by charris · Pull Request #28385 · numpy/numpy · GitHub
[go: up one dir, main page]
Skip to content

BUG: Make np.nonzero threading safe #28385

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
Feb 23, 2025
Merged

BUG: Make np.nonzero threading safe #28385

Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
4615d54
[ENH] add multi-threading test for np.nonzero
eendebakpt Feb 20, 2025
f506905
lint
eendebakpt Feb 20, 2025
1b73bdd
split test
eendebakpt Feb 20, 2025
ec14eff
fix buffer overflow
eendebakpt Feb 20, 2025
df22d5d
fix one more buffer overflow
eendebakpt Feb 20, 2025
de288cb
fix test
eendebakpt Feb 20, 2025
96cc64d
parameterize tests
eendebakpt Feb 20, 2025
fa697ad
MAINT: turn off halt_on_error on sanitizer CI
ngoldbaum Feb 21, 2025
4c9da47
attampt to add TSAN suppressions
eendebakpt Feb 21, 2025
2c9afc6
try to suppress
eendebakpt Feb 21, 2025
ef3c7d0
review comments
eendebakpt Feb 22, 2025
336a2c3
more suppressions
eendebakpt Feb 22, 2025
823b3f0
avoid race in writing
eendebakpt Feb 22, 2025
448da11
cleanup
eendebakpt Feb 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
lint
  • Loading branch information
@eendebakpt @charris
eendebakpt authored and charris committed Feb 23, 2025
commit f5069056a336572611794fe1dd6e748f1d35c528
2 changes: 1 addition & 1 deletion numpy/_core/tests/test_multithreading.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -278,7 +278,7 @@ def test_nonzero():
# In a second pass the indices of the non-zero elements are determined, but they can have changed

for dtype in [bool, int, float]:
x= np.random.randint(4, size=10_000).astype(dtype)
x = np.random.randint(4, size=10_000).astype(dtype)

def func(seed):
x[::2] = np.random.randint(2)
Expand Down
0