8000 BUG: Make np.nonzero threading safe by charris · Pull Request #28385 · numpy/numpy · GitHub
[go: up one dir, main page]

Skip to content

BUG: Make np.nonzero threading safe #28385

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
Feb 23, 2025
Prev Previous commit
Next Next commit
attampt to add TSAN suppressions
  • Loading branch information
eendebakpt authored and charris committed Feb 23, 2025
commit 4c9da471fb3da558d7f51d5e8a43c4c5da191ff8
2 changes: 1 addition & 1 deletion .github/workflows/compiler_sanitizers.yml
Original file line number Diff line number Diff line change
Expand Up @@ -121,7 +121,7 @@ jobs:
- name: Test
run: |
# These tests are slow, so only run tests in files that do "import threading" to make them count
TSAN_OPTIONS=allocator_may_return_null=1 \
TSAN_OPTIONS="allocator_may_return_null=1:halt_on_error=1:suppressions=tools\ci\tsan_suppressions.txt" \
python -m spin test \
`find numpy -name "test*.py" | xargs grep -l "import threading" | tr '\n' ' '` \
-- -v -s --timeout=600 --durations=10
9 changes: 9 additions & 0 deletions tools/ci/tsan_suppressions.txt
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
# This file contains suppressions for the TSAN tool
#
# Reference: https://github.com/google/sanitizers/wiki/ThreadSanitizerSuppressions


# These warnings trigger directly in a CPython function.

# For np.nonzero, see gh-28361
race:lowlevel_strided_loops.c.src
0