BLD: treat SVML object files better to avoid compiler warnings #27587
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GCC and Clang didn't mind passing unused compile flags when building object files, but the OneAPI Intel compilers emit warnings like: ``` [422/593] Compiling C object numpy/_core/_multiarray_umath.cpython-311-x86_64-linux-gnu.so.p/src_umath_svml_linux_avx512_svml_z0_asin_d_la.s.o icx: warning: argument unused during compilation: '-fvisibility=hidden' [-Wunused-command-line-argument] icx: warning: argument unused during compilation: '-fdiagnostics-color=always' [-Wunused-command-line-argument] icx: warning: argument unused during compilation: '-fno-strict-aliasing' [-Wunused-command-line-argument] icx: warning: argument unused during compilation: '-D NPY_HAVE_SSE2' [-Wunused-command-line-argument] ``` Those are fixed after this change. [skip cirrus] [skip circle]
|
Thanks Ralf. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GCC and Clang didn't mind passing unused compile flags when building object files, but the OneAPI Intel compilers emit lots of warnings like:
Those are fixed after this change. It also reduced the total number of build targets from 593 to 527 when building with SVML.