-
-
Notifications
You must be signed in to change notification settings - Fork 11k
CI: Build using Intel compiler #27544
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
crashed and burned, will figure out after the weekend :) |
@r-devulap note that SciPy has a working Linux CI job with the Intel LLVM compilers - probably easiest to copy that approach and modify. It's not so easy to get the right things installed with caching etc. |
Thanks for that. I will look it up. The workflow in the PR worked locally for me, so hoping this should be okay. |
yay, finally passed! @AgilentGCMS, any feedback here? Is there anything specific thing you want covered as part of CI? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @r-devulap, good to see this green. I think the test selection is wrong though - this just runs a small subset of tests (_linalg/ufunc/umath tests on Intel TGL) like for the SIMD tests, but I'd expect it to run the regular test suite instead. And then the job would be better placed in linux.yml
rather than in linux_simd.yml
. Is there a reason not to do this?
The build stage looks good. There was one minor issue with warnings for SVML object files, but that's unrelated to this job really so I opened a separate PR to fix that up (gh-27587).
Not sure if we really need this, closing for now. Will reopen if we need it at a later stage. |
Addressing #27492 (comment)