CI: don't use fetch-tags in wheel build jobs
#25995
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This failed in combination with tag-based triggers: - issue: numpygh-25979 - cause: numpy#25981 (comment) More importantly, we don't need to fetch either the tags or the whole commit history, because: (a) we don't derive the version number from the last tag, but from parsing pyproject.toml (b) we don't use a commit count, but only yyyymmdd.git-hash See `numpy/_build_utils/gitversion.py` Done only in the wheel build job right now, because that's where the problem is and we're in a hurry to solve it on the 2.0.x branch. However, this change should be fine everywhere. [skip cirrus] [skip circle] [skip azp]
|
Testing on my fork, all looking good: https://github.com/rgommers/numpy/actions/runs/8236127874 (modulo the Chocolatey issue that is apparently not resolved completely). @charris if you push this to |
|
Thanks Ralf. |
fetch-tags in wheel build jobsfetch-tags in wheel build jobs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This failed in combination with tag-based triggers:
More importantly, we don't need to fetch either the tags or the whole commit history, because:
(a) we don't derive the version number from the last tag, but from parsing pyproject.toml
(b) we don't use a commit count, but only yyyymmdd.git-hash
See
numpy/_build_utils/gitversion.pyDone only in the wheel build job right now, because that's where the problem is and we're in a hurry to solve it on the 2.0.x branch. However, this change should be fine everywhere.
[skip cirrus] [skip circle] [skip azp]