Action wheel builds do not happen when a tag is pushed. #25979
Comments
|
Xref #24535 |
|
here's how I run a build when a tag is pushed, for a personal project. |
That is not the case. There are way fewer triggers on this repo, and almost none on forks - it is now possible to find the actual runs on the first page of the action. And the email notifications went away completely. There are still some triggers on this repo, but that didn't seem avoidable given the setup. |
|
I'm tempted to revert the changes in #24535 just to get a release out. It would also help if manually running builds in a maintenance branch uploaded to staging. |
|
Please don't do that. The problem is #25981 (comment). I'll open a PR asap. |
This failed in combination with tag-based triggers: - issue: numpygh-25979 - cause: numpy#25981 (comment) More importantly, we don't need to fetch either the tags or the whole commit history, because: (a) we don't derive the version number from the last tag, but from parsing pyproject.toml (b) we don't use a commit count, but only yyyymmdd.git-hash See `numpy/_build_utils/gitversion.py` Done only in the wheel build job right now, because that's where the problem is and we're in a hurry to solve it on the 2.0.x branch. However, this change should be fine everywhere. [skip cirrus] [skip circle] [skip azp]
Good point. That requires some extra config. I just learned that it's possible to add options to manual triggers; https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#onworkflow_dispatchinputs. Perhaps choosing nighty vs. staging manually is useful? |
This failed in combination with tag-based triggers: - issue: numpygh-25979 - cause: numpy#25981 (comment) More importantly, we don't need to fetch either the tags or the whole commit history, because: (a) we don't derive the version number from the last tag, but from parsing pyproject.toml (b) we don't use a commit count, but only yyyymmdd.git-hash See `numpy/_build_utils/gitversion.py` Done only in the wheel build job right now, because that's where the problem is and we're in a hurry to solve it on the 2.0.x branch. However, this change should be fine everywhere. [skip cirrus] [skip circle] [skip azp]
This turned up when building wheels for v2.0.0b1, I needed to trigger them manually. I assume this is because
push:has been removed from.github/workflows/wheels.yml.Another potential problem is that the commit has both a tag and
[wheel build]. I also wonder why only use the first line of the commit when looking for[wheel build]. I note thegit log -1 --grep '\[wheel build\]'will also find the directive.The text was updated successfully, but these errors were encountered: