8000 DOC: try to be nicer about f2py.compile by HaoZeke · Pull Request #25194 · numpy/numpy · GitHub
[go: up one dir, main page]

Skip to content

DOC: try to be nicer about f2py.compile #25194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 22, 2023

Conversation

HaoZeke
Copy link
Member
@HaoZeke HaoZeke commented Nov 20, 2023

The nicer version of #25193. Perhaps to be merged now and that can go in later.

@HaoZeke HaoZeke force-pushed the deprecateCompileFunc branch 3 times, most recently from 4006213 to 75a3eb8 Compare November 20, 2023 02:30
@HaoZeke HaoZeke force-pushed the deprecateCompileFunc branch from 75a3eb8 to db987d6 Compare November 20, 2023 21:40
@HaoZeke
Copy link
Member Author
HaoZeke commented Nov 20, 2023

@mattip would it make sense to merge this for now and put #25193 when 2.0.0 is cut?

@mattip
Copy link
Member
mattip commented Nov 21, 2023

@melissawm thoughts?

Copy link
Member
@melissawm melissawm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable to me, thanks @HaoZeke !

Comment on lines +85 to +87
"Write a custom subprocess.run wrapper to f2py instead",
VisibleDeprecationWarning,
stacklevel=2,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we want to include an example of this in the f2py docs.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 yup, though I think that'd be better suited to #25193.

@rgommers
Copy link
Member

@mattip would it make sense to merge this for now and put #25193 when 2.0.0 is cut?

I'm not sure I understand this. If we want to remove f2py.compile, the time is either now, or otherwise a couple of releases into the future. Why not do it right now?

@HaoZeke
Copy link
Member Author
HaoZeke commented Nov 22, 2023

@mattip would it make sense to merge this for now and put #25193 when 2.0.0 is cut?

I'm not sure I understand this. If we want to remove f2py.compile, the time is either now, or otherwise a couple of releases into the future. Why not do it right now?

I was wondering about the off-chance that it is being used and the downstream users would like some time to migrate away from it (though they really should so we can't keep it around forever). @seberg mentioned the release of 2.0 would be sometime early next year so there's still some time for people who update their versions regularly to get ahead of any issues they'd have.

@rgommers
Copy link
Member

Well, we want to branch in a month and a bit I think, if everything goes well. And users of this - of which there will be few - are not likely to going to need it from a dev version. We have a lot of stuff to get in for 2.0, so if this is ready to go we should put it in.

@rgommers
Copy link
Member

Okay, this is approved, so I'll hit the green button. Let's not leave anything to right before the branch cut though.

@rgommers rgommers merged commit 4d98763 into numpy:main Nov 22, 2023
@rgommers
Copy link
Member

Thank Rohit & reviewers!

@rgommers rgommers added this to the 2.0.0 release milestone Nov 22, 2023
@rgommers rgommers changed the title DOC: Try to be nicer about compile DOC: try to be nicer about f2py.compile Nov 22, 2023
@HaoZeke HaoZeke deleted the deprecateCompileFunc branch November 22, 2023 21:08
@charris charris added 09 - Backport-Candidate PRs tagged should be backported and removed 09 - Backport-Candidate PRs tagged should be backported labels Dec 24, 2023
@HaoZeke HaoZeke restored the deprecateCompileFunc branch June 15, 2024 23:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants
0