8000 MAINT: Kill all instances of f2py.compile by HaoZeke · Pull Request #25193 · numpy/numpy · GitHub
[go: up one dir, main page]
Skip to content

MAINT: Kill all instances of f2py.compile #25193

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 23, 2023
Merged

MAINT: Kill all instances of f2py.compile #25193

merged 2 commits into from
Nov 23, 2023

Conversation

HaoZeke
Copy link
Member
@HaoZeke HaoZeke commented Nov 20, 2023 •
edited
Loading

Closes #25122 with my favored resolution. There was no dissent on the mailing list either. I'm happy to have this float around until 2.0.0 (hence the versionchanged in the docs) but it should go, sooner perhaps rather than later.

@HaoZeke HaoZeke mentioned this pull request Nov 20, 2023
Merged
mattip
mattip approved these changes Nov 20, 2023
View reviewed changes
Copy link
Member
@mattip mattip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. One small nit about the release note, and a question about using environment variables.

doc/release/upcoming_changes/25193.compatibility.rst Outdated
The ``f2py.compile()`` helper has been removed due to a severe restriction in
functionality after the ``meson`` switch. Users are urged to replace these calls
with ``subprocess.run`` calls to ``python -m numpy.f2py`` instead with
environment variables set to interact with ``meson``.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm. The use of environment variables is problematic. Isn't there any other way to hook into meson?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are native files, I've added a note.

@HaoZeke HaoZeke requested a review from mattip November 20, 2023 21:42
@rgommers rgommers added this to the 2.0.0 release milestone Nov 22, 2023
@rgommers
Copy link
Member

The test_f2py_init_compile tests are also very slow and missing the slow test marker, so this will be nice to get in too. @HaoZeke it may be worth running the f2py tests with --durations=25 and adding more slow markers. Just the f2py tests (default, fast) is taking about 100 seconds for me right now, that is much too long.

rgommers
rgommers reviewed Nov 23, 2023
View reviewed changes
Copy link
Member
@rgommers rgommers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM, after a small rephrase of the release note and resolving the merge conflicts, I think this can go in.

@HaoZeke HaoZeke mentioned this pull request Nov 23, 2023
Merged
7 tasks
HaoZeke and others added 2 commits November 23, 2023 15:38
@HaoZeke
MAINT: Kill all instances of f2py.compile
f8fb517
@HaoZeke @rgommers
DOC: Document the loss of f2py.compile in the news
764c64e 
MAINT: Fix typo

DOC: Add a note on native files

DOC: Update changelog

Co-authored-by: Matti Picus <matti.picus@gmail.com>

DOC: Update release note

Co-authored-by: rgommers <rgommers@users.noreply.github.com>
@HaoZeke HaoZeke requested a review from rgommers November 23, 2023 15:40
rgommers
rgommers approved these changes Nov 23, 2023
View reviewed changes
Copy link
Member
@rgommers rgommers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM now, in it goes. Thanks Rohit!

@rgommers rgommers merged commit 5b4dab8 into numpy:main Nov 23, 2023
@HaoZeke HaoZeke deleted the killCompileFunc branch November 23, 2023 22:26
@HaoZeke HaoZeke restored the killCompileFunc branch June 15, 2024 23:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rgommers rgommers rgommers approved these changes

@mattip mattip Awaiting requested review from mattip

Assignees
No one assigned
Labels
03 - Maintenance 07 - Deprecation component: numpy.f2py
Projects
None yet
Milestone
2.0.0 release
Development

Successfully merging this pull request may close these issues.

RFC: Getting rid of numpy.f2py.compile()
3 participants
@HaoZeke @rgommers @mattip
0