8000 CI: remove spurious wheel build action runs by rgommers · Pull Request #24535 · numpy/numpy · GitHub
[go: up one dir, main page]
Skip to content

CI: remove spurious wheel build action runs #24535

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 27, 2023
Merged

CI: remove spurious wheel build action runs #24535

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 3 additions & 5 deletions .github/workflows/wheels.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,9 +22,10 @@ on:
# │ │ │ │ ┌───────────── day of the week (0 - 6 or SUN-SAT)
# │ │ │ │ │
- cron: "42 2 * * SUN,WED"
push:
Copy link
Member
@andyfaff andyfaff Aug 25, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are there any circumstances where a push commit would be useful, over the manual start?

Copy link
Member Author
@rgommers rgommers Aug 25, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think only maintainers can push the Run workflow button, so that may be useful to keep for now. [wheel build] isn't super pretty, but at least it doesn't cause any problems.

pull_request:
types: [labeled, opened, synchronize, reopened]
branches:
- main
- maintenance/**
workflow_dispatch:

concurrency:
Expand Down Expand Up @@ -62,9 +63,6 @@ jobs:
contains(needs.get_commit_message.outputs.message, '[wheel build]') ||
github.event_name == 'schedule' ||
github.event_name == 'workflow_dispatch' ||
(github.event_name == 'pull_request' &&
(contains(github.event.pull_request.labels.*.name, '36 - Build') ||
contains(github.event.pull_request.labels.*.name, '14 - Release'))) ||
(github.event_name == 'push' && startsWith(github.ref, 'refs/tags/v') && ( ! endsWith(github.ref, 'dev0')))
runs-on: ${{ matrix.buildplat[0] }}
strategy:
Expand Down
0