CI: remove spurious wheel build action runs #24535
Conversation
[skip azp] [skip cirrus] [skip circle] [skip travis]
|
Ah, I noticed that there are some docs on this in https://numpy.org/devdocs/dev/development_workflow.html#test-building-wheels. I'll remove those in a follow-up PR, and will add instructions on how to work on CI jobs on one's own fork, that would be useful for folks it looks like. |
|
Finally, let me note that the way to trigger wheel builds without pushing a commit is to go to https://github.com/numpy/numpy/actions/workflows/wheels.yml and press the "run workflow" button: 
We do not need these label-based things, and they're actually actively counterproductive (wastes a ton of resources, when typically all you want is trigger the builds once, not over and over run ~20 extra jobs on the same PR). |
| @@ -22,9 +22,10 @@ on: | |||
| # │ │ │ │ ┌───────────── day of the week (0 - 6 or SUN-SAT) | |||
| # │ │ │ │ │ | |||
| - cron: "42 2 * * SUN,WED" | |||
| push: | |||
There was a problem hiding this comment.
are there any circumstances where a push commit would be useful, over the manual start?
There was a problem hiding this comment.
I think only maintainers can push the Run workflow button, so that may be useful to keep for now. [wheel build] isn't super pretty, but at least it doesn't cause any problems.
|
The only problem with hitting the button for manual builds is that they don't run cirrus. They cannot be run from cirrus either, I think the cirrus yml needs to allow that. |
True, that's what |
|
This has a LGTM and it's useful to me to reduce spam when working on the remaining CI tasks from gh-24410, so I'll hit the green button here. |
These unusual label-based and push-based triggers have several negative consequences:
This is too spammy, and the usefulness of the extra triggers is low. So making them the same as in all other GHA workflow files.