MAINT: Address Nathans review comments

numpy · ngoldbaum · Oct 24, 2023 · Jun 9, 2023 · Jun 9, 2023 · Jun 9, 2023
commit 35e105f92e6778d273b7ece2d863599effa347a1
diff --git a/doc/source/user/basics.creation.rst b/doc/source/user/basics.creation.rst
@@ -44,19 +44,14 @@ consider the :doc:`dtype <basics.types>` of the elements in the array,
 which can be specified explicitly. This feature gives you
 more control over the underlying data structures and how the elements
 are handled in C/C++ functions.
-When values do not fit and you are using a ``dtype`` NumPy may raise an
+When values do not fit and you are using a ``dtype``, NumPy may raise an
 error::
 
   >>> np.array([127, 128, 129], dtype=np.int8)
   Traceback (most recent call last):
   ...
   OverflowError: Python integer 128 out of bounds for int8
 
-However, NumPy integers are force-cast and may silently overflow::
-
-  >>> np.array([127, np.int64(128), np.int64(129)], dtype=np.int8)
-  array([ 127, -128, -127], dtype=int8)
-
 An 8-bit signed integer represents integers from -128 to 127.
 Assigning the ``int8`` array to integers outside of this range results
 in overflow. This feature can often be misunderstood. If you

diff --git a/numpy/_core/src/multiarray/multiarraymodule.c b/numpy/_core/src/multiarray/multiarraymodule.c
@@ -3252,7 +3252,7 @@ array_set_datetimeparse_function(PyObject *NPY_UNUSED(self),
 NPY_NO_EXPORT PyObject *
 PyArray_Where(PyObject *condition, PyObject *x, PyObject *y)
 {
-    PyArrayObject *arr, *ax, *ay = NULL;
+    PyArrayObject *arr = NULL, *ax = NULL, *ay = NULL;
     PyObject *ret = NULL;
     PyArray_Descr *common_dt = NULL;
 
@@ -3300,6 +3300,7 @@ PyArray_Where(PyObject *condition, PyObject *x, PyObject *y)
     if (common_dt == NULL) {
         goto fail;
     }
+    /* `PyArray_DescrFromType` cannot fail for simple builtin types: */
     PyArray_Descr * op_dt[4] = {common_dt, PyArray_DescrFromType(NPY_BOOL),
                                 common_dt, common_dt};
     NpyIter * iter;

diff --git a/numpy/_core/src/umath/ufunc_object.c b/numpy/_core/src/umath/ufunc_object.c
@@ -944,6 +944,8 @@ convert_ufunc_arguments(PyUFuncObject *ufunc,
              *       We should eventually have special loops for isnan and once
              *       we do, we may just deprecate all remaining ones (e.g.
              *       `negative(2**100)` not working as it is an object.)
+             *
+             *       This is issue is part of the NEP 50 adoption.
              */
             break;
         }