8000 API: Switch to NEP 50 behavior by default by seberg · Pull Request #23912 · numpy/numpy · GitHub
[go: up one dir, main page]
Skip to content

API: Switch to NEP 50 behavior by default #23912

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 27 commits into from
Oct 24, 2023
Merged

API: Switch to NEP 50 behavior by default #23912

Changes from 1 commit
Commits
Show all changes
27 commits
Select commit Hold shift + click to select a range
197e61c
API: Switch to "weak" promotion state by default
seberg Jun 9, 2023
af5fe2e
MAINT,TST: Fix issues due to out-of-range integers
seberg Jun 9, 2023
14f6aa1
MAINT: Robustify histogram unsigned-subtract and fix test for NEP 50
seberg Jun 9, 2023
0cc124d
TST: Adjust tests for direct NEP 50 changes
seberg Jun 9, 2023
e19fd64
TST: Straight forward NEP 50 fixup or longdouble+int scalar tests
seberg Jun 9, 2023
1f07c93
STY: Remove unnecessary indentation level
seberg Jun 26, 2023
e445e80
API: Use weak scalar logic in where (and fix up error paths slightly)
seberg Jun 26, 2023
346a146
TST: Adept where test to NEP 50
seberg Jun 26, 2023
166e806
MAINT: Require `select` for NEP 50 support
seberg Jul 12, 2023
6cf68f3
Fix percentile and quantile
mhvk Jul 12, 2023
623e0f0
TST: xfail test that checks `can_cast()` beahvior with pyints
seberg Sep 28, 2023
0f18c6f
MAINT: Also adopt `q` handling from the main quantile/percnetile to n…
seberg Sep 28, 2023
94b7f90
MAINT: Address review comments by Marten
seberg Sep 28, 2023
841a280
TST: Fix one more tests
seberg Sep 28, 2023
09418fc
TYP: Fix typing passing test which cannot pass anymore
seberg Sep 28, 2023
df8f9d6
DOC: Fix docs that cause an integer overflow
seberg Sep 28, 2023
8a1497f
MAINT: Avoid overflow in comparison with int64 on shorter platforms
seberg Sep 28, 2023
0aa93fa
DOC: Fix docstring pointing out quirks that got less bad with NEP 50
seberg Sep 28, 2023
375de5d
TST: Undo test changes related to comparising to out-of-bound ints
seberg Oct 12, 2023
0e6d569
MAINT: Undo now unnecessary random number cast to int64
seberg Oct 12, 2023
a907624
API: Disable `can_cast` with Python scalars (for now)
seberg Oct 12, 2023
dcb8de2
TST: Adjust test to avoid overflow (and bad results on BSD)
seberg Oct 12, 2023
6707f39
BENCH: Explicitly skip reversed (arg)partition case because they fail
seberg Oct 12, 2023
ba47e60
MAINT: Address review comments
seberg Oct 20, 2023
bf0ff21
MAINT: Clean up error path (DescrFromType cannot fail for simple buil…
seberg Oct 23, 2023
35e105f
MAINT: Address Nathans review comments
seberg Oct 24, 2023
b5c8398
MAINT: appease linter
ngoldbaum Oct 24, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8000
Next Next commit
API: Switch to "weak" promotion state by default
  • Loading branch information
@seberg
seberg committed Oct 19, 2023
commit 197e61c6bbca7b35414f341f0596391ecf17a31f
4 changes: 2 additions & 2 deletions numpy/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -517,9 +517,9 @@ def hugepage_setup():
# it is tidier organized.
_core.multiarray._multiarray_umath._reload_guard()

# TODO: Switch to defaulting to "weak".
# TODO: Remove the environment variable entirely now that it is "weak"
_core._set_promotion_state(
os.environ.get("NPY_PROMOTION_STATE", "legacy"))
os.environ.get("NPY_PROMOTION_STATE", "weak"))

# Tell PyInstaller where to find hook-numpy.py
def _pyinstaller_hooks_dir():
Expand Down
0