8000 BUG: Add extern to PyArrayDTypeMeta_Type declaration by seberg · Pull Request #16435 · numpy/numpy · GitHub
[go: up one dir, main page]
Skip to content

BUG: Add extern to PyArrayDTypeMeta_Type declaration #16435

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 29, 2020
Merged

BUG: Add extern to PyArrayDTypeMeta_Type declaration #16435

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
BUG: Add extern to PyArrayDTypeMeta_Type declaration 
This was missing the extern, but pre GCC 10 it seemed to have worked
fine without.

Closes gh-16419
  • Loading branch information
@seberg
seberg committed May 29, 2020
commit a811b099bd4a53746613d799dd79882b888dc16e
2 changes: 1 addition & 1 deletion numpy/core/include/numpy/ndarraytypes.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1821,7 +1821,7 @@ typedef void (PyDataMem_EventHookFunc)(void *inp, void *outp, size_t size,
* may change without warning!
*/
/* TODO: Make this definition public in the API, as soon as its settled */
NPY_NO_EXPORT PyTypeObject PyArrayDTypeMeta_Type;
NPY_NO_EXPORT extern PyTypeObject PyArrayDTypeMeta_Type;

/*
* While NumPy DTypes would not need to be heap types the plan is to
Expand Down
0