8000 BUG: Add extern to PyArrayDTypeMeta_Type declaration by seberg · Pull Request #16435 · numpy/numpy · GitHub
[go: up one dir, main page]
Skip to content

BUG: Add extern to PyArrayDTypeMeta_Type declaration #16435

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 29, 2020
Merged

BUG: Add extern to PyArrayDTypeMeta_Type declaration #16435

merged 1 commit into from
May 29, 2020

Conversation

seberg
Copy link
Member
@seberg seberg commented May 29, 2020

This was missing the extern, but pre GCC 10 it seemed to have worked
fine without.

Closes gh-16419

@seberg
BUG: Add extern to PyArrayDTypeMeta_Type declaration
a811b09 
This was missing the extern, but pre GCC 10 it seemed to have worked
fine without.

Closes numpygh-16419
@seberg seberg mentioned this pull request May 29, 2020
Closed
rossbar
rossbar approved these changes May 29, 2020
View reviewed changes
Copy link
Contributor
@rossbar rossbar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This resolved the build issue on my system with gcc 10.1

@charris charris merged commit 470c783 into numpy:master May 29, 2020
@charris
Copy link
Member
charris commented May 29, 2020

Thanks Sebastian.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rossbar rossbar rossbar approved these changes

Assignees
No one assigned
Labels
00 - Bug component: numpy._core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Problem compiling numpy with GCC 10.1
3 participants
@seberg @charris @rossbar
0