8000 MAINT: Chain exceptions in npyio.py by smitgajjar · Pull Request #16218 · numpy/numpy · GitHub
[go: up one dir, main page]
Skip to content

MAINT: Chain exceptions in npyio.py #16218

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

MAINT: Chain exceptions in npyio.py #16218

wants to merge 1 commit into from

Conversation

smitgajjar
Copy link

This PR is related to the issue #15986.

rossbar
rossbar reviewed May 13, 2020
View reviewed changes
Copy link
Contributor
@rossbar rossbar left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking a look! It looks like a few of these changes overlap with some changes proposed in #16121 . I will ping the author there to clarify the status and minimize duplication.

In the mean time, some proposed changes related to exception chaining in npyio.py were already reviewed in #15731. I didn't look too carefully, but it might be worthwhile to see if any of the review comments there apply to the proposed changes here.

@rossbar
Copy link
Contributor
rossbar commented May 13, 2020

Note that one comment from #15731 applies here - it would be an aid to reviewers if you were able to provide quick examples that raise the exceptions you propose to change. This isn't necessary, but would likely speed the review process!

@smitgajjar
Copy link
Author
smitgajjar commented May 14, 2020 •
edited
Loading

Thanks for taking a look! It looks like a few of these changes overlap with some changes proposed in #16121 .

I didn't know, this was covered in that PR. I think it will be better for that author to continue! Hence, closing this now!

Note that one comment from #15731 applies here - it would be an aid to reviewers if you were able to provide quick examples that raise the exceptions you propose to change. This isn't necessary, but would likely speed the review process!

Thanks, will be careful about that in the next similar PR

@smitgajjar smitgajjar closed this May 14, 2020
@smitgajjar smitgajjar deleted the chain-exception branch May 14, 2020 14:27
@nkleinbaer nkleinbaer mentioned this pull request Jul 18, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rossbar rossbar rossbar left review comments

Assignees
No one assigned
Labels
03 - Maintenance component: numpy.lib
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@smitgajjar @rossbar @charris
0