8000 MAINT: Chain exceptions in several places by keremh · Pull Request #16121 · numpy/numpy · GitHub
[go: up one dir, main page]
Skip to content

MAINT: Chain exceptions in several places #16121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jun 30, 2020
Merged

MAINT: Chain exceptions in several places #16121

merged 4 commits into from
Jun 30, 2020

Conversation

keremh
Copy link
Contributor
@keremh keremh commented Apr 30, 2020

this solution is related to the following issue #15986
@eric-wieser can you review this pr?
Thank you.

eric-wieser
eric-wieser reviewed Apr 30, 2020
View reviewed changes
@keremh keremh force-pushed the fix-exception-raise branch from c4ffbc1 to 4491f42 Compare May 1, 2020 17:51
rossbar
rossbar reviewed May 8, 2020
View reviewed changes
@rossbar
Copy link
Contributor
rossbar commented May 13, 2020

@keremh - a gentle ping to see if you are still interested in pursuing these changes. It looks all that remains is to address comments about changing the tests then this should be ready for re-review. Note the CI failure is unrelated.

@smitgajjar smitgajjar mentioned this pull request May 14, 2020
Closed
@rossbar rossbar force-pushed the fix-exception-raise branch from 6ae57dd to f9a1d03 Compare June 29, 2020 23:35
@rossbar
Copy link
Contributor
rossbar commented Jun 29, 2020

This PR seemed to have gotten stuck on some merge conflicts following #16633, so I went ahead and rebased on master to try to get everything back to a reviewable state. I also took the liberty of incorporating the bit of feedback from previous reviews about not modifying the handling of exceptions in the tests.

I did notice one last thing: it seems strange that loadtxt and genfromtxt raise different classes of exception in very similar scenarios... but I don't want to overload this PR too much - we'll see if maybe @eric-wieser or @seberg can give it a final once-over then we can get this in.

@seberg
Copy link
Member
seberg commented Jun 30, 2020

Looks good to me, thanks everyone.

@seberg seberg merged commit f38073b into numpy:master Jun 30, 2020
@nkleinbaer nkleinbaer mentioned this pull request Jul 18, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eric-wieser eric-wieser eric-wieser left review comments

@rossbar rossbar rossbar left review comments

Assignees
No one assigned
Labels
03 - Maintenance component: numpy.ctypes component: numpy.lib
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@keremh @rossbar @seberg @eric-wieser @charris
0