8000 MAINT: Remove unused int_asbuffer by jdufresne · Pull Request #15229 · numpy/numpy · GitHub
[go: up one dir, main page]
Skip to content

MAINT: Remove unused int_asbuffer #15229

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 4, 2020
Merged

MAINT: Remove unused int_asbuffer #15229

merged 1 commit into from
Jan 4, 2020

Conversation

jdufresne
Copy link
Contributor

On Python 3, int_asbuffer throws NotImplementedError and goes unused
internally.

Fixes #12425

@jdufresne jdufresne changed the title Remove unused int_asbuffer MAINT: Remove unused int_asbuffer Jan 3, 2020
@seberg seberg added 62 - Python API Changes or additions to the Python API. Mailing list should usually be notified. 03 - Maintenance and removed 62 - Python API Changes or additions to the Python API. Mailing list should usually be notified. labels Jan 3, 2020
@seberg
Copy link
Member
seberg commented Jan 3, 2020

Does anyone feel this should get a release note? I am tempted to simply put this this in as is (and may do so if no one disagrees in the next days).

@charris
Copy link
Member
charris commented Jan 3, 2020

Release notes are cheap :)

@seberg seberg added the 56 - Needs Release Note. Needs an entry in doc/release/upcoming_changes label Jan 3, 2020
@jdufresne
MAINT: Remove unused int_asbuffer
963692d 
On Python 3, int_asbuffer throws NotImplementedError and goes unused
internally.

Fixes #12425
@jdufresne
Copy link
Contributor Author

I added some release notes. Let me know if this is what you had in mind. All feedback on wording and format welcome.
8000

@mattip mattip merged commit 1d9595f into numpy:master Jan 4, 2020
@mattip
Copy link
Member
mattip commented Jan 4, 2020

Thanks @jdufresne

@jdufresne jdufresne deleted the int_asbuffer branch January 4, 2020 17:00
@sethtroisi sethtroisi mentioned this pull request Jan 6, 2020
Merged
@seberg seberg mentioned this pull request Mar 5, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
03 - Maintenance 56 - Needs Release Note. Needs an entry in doc/release/upcoming_changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove int_asbuffer
4 participants
@jdufresne @seberg @charris @mattip
0