BUG: fix release snippet failures caught only after merging #14526
Conversation
| @@ -1687,8 +1687,6 @@ def add_npy_pkg_config(self, template, install_dir, subst_dict=None): | |||
|
|
|||
| and will be installed as foo.ini in the 'lib' subpath. | |||
|
|
|||
| Cross-compilation | |||
| ----------------- | |||
There was a problem hiding this comment.
This is not a valid docstring section name
f1a29fb to
976fff7
Compare
| If ``drop_fields`` is used to drop all fields, previously the array would | ||
| be completely discarded and ``None`` returned. Now it returns an array of the | ||
| be completely discarded and `None` returned. Now it returns an array of the | ||
| same shape as the input, but with no fields. The old behavior can be retained |
There was a problem hiding this comment.
Was this note really broken?
There was a problem hiding this comment.
The note was fine. The issue is that when the template consumes it, no blank line was added after the note. That meant the code block had no blank line after it, which sphinx RST doesn't like.
There was a problem hiding this comment.
OK, I think I like the solution of just adding a bit of text under the fragment best. Feels a bit wrong that there is no better way, but if we like the autmatic addition of the link it is a bit tricky (unless we remove automatic whitespace stripping, but...). Did not realize None was fine with single quotes.
|
OK, let me put this in before test failures start to be annoying. Thanks Matti. |
|
If a better solution is found, it can be merged. Also we could have replaced this line with |
#14514 added a test for building towncrier notes. For some reason the test passed in the merge even though it left master with a bad file name?