8000 DOC: Build release notes during CircleCI step by seberg · Pull Request #14514 · numpy/numpy · GitHub
[go: up one dir, main page]
Skip to content

DOC: Build release notes during CircleCI step #14514

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 16, 2019
Merged

DOC: Build release notes during CircleCI step #14514

merged 1 commit into from
Sep 16, 2019

Conversation

seberg
Copy link
Member
@seberg seberg commented Sep 15, 2019

For the moment, this requires te use for the development version
of towncrier.

I will check CI, there are likely smaller things that needs fixing in existing fragments, if not, I may just merge soon, so that the fragments are tested (at least for rst errors).

@seberg seberg force-pushed the towncrier-ci 8000 branch 2 times, most recently from b6d65e2 to b3bc936 Compare September 15, 2019 04:19
mattip
mattip reviewed Sep 15, 2019
View reviewed changes
@seberg seberg force-pushed the towncrier-ci branch 2 times, most recently from 5e00f83 to dc83da1 Compare September 15, 2019 05:37
mattip
mattip reviewed Sep 15, 2019
View reviewed changes
@seberg seberg force-pushed the towncrier-ci branch 3 times, most recently from 981ffda to 85b230b Compare September 15, 2019 05:56
mattip
mattip reviewed Sep 15, 2019
View reviewed changes
mattip
mattip reviewed Sep 15, 2019
View reviewed changes
@seberg seberg force-pushed the towncrier-ci branch 4 times, most recently from 85814c3 to 0a2d097 Compare September 15, 2019 07:19
@seberg
Copy link
Member Author
seberg commented Sep 15, 2019

OK, tested locally, sorry for the previous spam. The test script triggers, the release notes seem to render fine.

@mattip
Copy link
Member
mattip commented Sep 15, 2019

here is the rendered note. Might as well fix up the formatting problems in this note.

I like the way towncrier adds a link to the PR.

@seberg
DOC,MAINT: Build release notes during CircleCI step
958a6b5 
For the moment, this requires te use for the development version
of towncrier.
@seberg
Copy link
Member Author
seberg commented Sep 15, 2019

Rephrased that one slightly. Just noticed that towncrier has a small bug with the new single file option. It was supposed to ignore existing content (and default to old behaviour). Not a big issue, although I suppose we may have to adapt the pyproject.toml once that is fixed (if you scroll down the old content is still there at the end).

@mattip mattip merged commit a23ab78 into numpy:master Sep 16, 2019
@mattip
Copy link
Member
mattip commented Sep 16, 2019

Thanks @seberg. The first iteration of the final release note may need some editing by hand, but this will allow us to see the note as it evolves.

@mattip mattip mentioned this pull request Sep 16, 2019
Merged
@seberg seberg deleted the towncrier-ci branch September 16, 2019 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattip mattip mattip left review comments

Assignees
No one assigned
Labels
04 - Documentation component: CI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@seberg @mattip @charris
0