8000 DEP: promise to remove a file in 1.17 by mattip · Pull Request #12475 · numpy/numpy · GitHub
[go: up one dir, main page]
Skip to content

DEP: promise to remove a file in 1.17 #12475

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

DEP: promise to remove a file in 1.17 #12475

wants to merge 1 commit into from

Conversation

mattip
Copy link
Member
@mattip mattip commented Dec 2, 2018

PR #12402 will remove the noprefix.h header file. Notify users already in 1.16 that this will happen in 1.17

@rgommers
Copy link
Member
rgommers commented Dec 2, 2018

I feel like the discussion in gh-12402 isn't yet settled. SciPy explicitly includes this file, so this would already break the SciPy 1.2.0 + NumPy 1.17.0 build. Hence not in favor.

@mattip mattip mentioned this pull request Dec 2, 2018
Merged
@rgommers
Copy link
Member
rgommers commented Dec 3, 2018

Another use in matplotlib: https://github.com/matplotlib/matplotlib/blob/master/src/qhull_wrap.c#L9. Will comment more in gh-12402

@mattip mattip mentioned this pull request Dec 11, 2018
Merged
@mattip mattip closed this Dec 11, 2018
@mattip mattip deleted the deprecate-noprefix branch March 4, 2019 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
04 - Documentation 07 - Deprecation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mattip @rgommers
0