ENH: replace deprecated numpy header #12976
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fwiw, tests pass but when I did this for Scipy, building wheels failed. The surgery there was much deeper, but I thought I would mention it. xref scipy/scipy#9561 |
anntzer
approved these changes
Dec 11, 2018
|
Can backport this more aggressively (to 3.0.x and 2.2.x) if @mattip and numpy prefer. Seems like an odd change to make in a patch release, but this change should not be user-facing and I see the value of keeping old version forward compatible (even after we stop doing releases for them). |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Exchange an old (should be deprecated) header with the modern alternative
xref numpy/numpy#12475, numpy/numpy#12402