MAINT: More Histogramdd cleanup #10863
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`x1d[nonzero(mask1d)[0]]` is just a less readable way to spell `x1d[mask1d]`
len(xy) == N, and we already checked if N == 0 above.
…larger array The result is left as a float, even though it no longer needs to be, as this commit aims not to change behavior.
Creates an alias instead
charris
reviewed
Apr 9, 2018
| Ncount = tuple( | ||
| np.digitize(sample[:, i], edges[i]) | ||
| for i in _range(D) | ||
| ) |
There was a problem hiding this comment.
I think these look better when aligned with the arguments.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lots of small and unrelated cleanups, each just a few lines. Submitted as one PR to minimize email noise, but the commits are self-contained.
This doesn't attempt to change any outward-facing behavior - it just makes the oddities (#7845, #10864) stand out more.