-
-
Notifications
You must be signed in to change notification settings - Fork 10.9k
histogram2d and histogramdd always return a float array #7845
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
This would be one more aspect to consolidate across |
Yes agreed, I will bring |
…levant, in line with histogram
Channeling @charris:
If we decide to go ahead with the change, the fix is simply to remove Lines 937 to 938 in cc1107e
|
The mailing list link given above is dead. I think this is the correct thread: https://mail.python.org/archives/list/numpy-discussion@python.org/thread/NIHE7UT4SDPU6KCDSMUIU2UA52PDSEIJ/ |
When no normalization is performed the
histogram*d
functions should return anint
array, just ashistogram
does. Afloat
array is returned instead.The docs of
histogram2d
don't mention anything about return type, but also don't follow the style of the docs ofhistogram
, in which it is stated that semantics depend on normalization (I guess this could be written more explicitly).histogramdd
does follow the doc style ofhistogram
, but also returns afloat
array, likehistogram2d
does.Running NumPy 1.11.0 on Ubuntu 14.04
Sample code:
The text was updated successfully, but these errors were encountered: