10000 Add List by kanghyojun · Pull Request #65 · nirum-lang/nirum-python · GitHub
[go: up one dir, main page]
Skip to content

Add List #65

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Mar 20, 2017
Merged

Add List #65

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
8b873de
Add ImmutableList
Mar 19, 2017
69e3bf7
Rename it
Mar 19, 2017
e04a9b3
Move test code to datastructures_test.py
kanghyojun Mar 20, 2017
1411455
Rename ImmutableList -> List
kanghyojun Mar 20, 2017
28de0e0
Teset whether immutable_list is mutable or not
kanghyojun Mar 20, 2017
a1ab6f5
Write changelog for nirum.datastructures.List
kanghyojun Mar 20, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Rename ImmutableList -> List
  • Loading branch information
@kanghyojun
kanghyojun committed Mar 20, 2017
commit 1411455f7c7b3ce9a106b83e482cd58227baaea7
8 changes: 4 additions & 4 deletions nirum/datastructures.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
"""
import collections

__all__ = 'Map', 'ImmutableList'
__all__ = 'List', 'Map'


class Map(collections.Mapping):
Expand Down Expand Up @@ -51,7 +51,7 @@ def __repr__(self):
return '{0.__module__}.{0.__name__}({1})'.format(type(self), args)


class ImmutableList(collections.Sequence):
class List(collections.Sequence):

def __init__(self, l):
self.l = l
Expand All @@ -71,5 +71,5 @@ def __iter__(self):
def index(self, item):
return self.l.index(item)

def count(self):
return self.l.count()
def count(self, item):
return self.l.count(item)
6 changes: 3 additions & 3 deletions tests/datastructures_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@

from pytest import raises

from nirum.datastructures import Map, ImmutableList
from nirum.datastructures import List, Map


def test_map_init():
Expand Down Expand Up @@ -70,8 +70,8 @@ def test_map_repr():
assert repr(Map(a=1, b=2)) == "nirum.datastructures.Map({'a': 1, 'b': 2})"


def test_immutable_list():
immutable_list = ImmutableList([1, 2])
def test_list():
immutable_list = List([1, 2])
with raises(AttributeError):
immutable_list.append(1)

Expand Down
0