Add List #65
Merged
Add List #65
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dahlia
requested changes
Mar 19, 2017
tests/types_test.py
Outdated
| assert immutable_list.index(2) == 1 | ||
| assert immutable_list.count(1) == 1 | ||
| assert immutable_list.count(2) == 1 | ||
| assert immutable_list.count(3) == 0 |
nirum/datastructures.py
Outdated
| __all__ = 'ImmutableList', | ||
|
|
||
|
|
||
| class ImmutableList(collections.Sequence): |
There was a problem hiding this comment.
니름쪽과 같은 이름으로 간단하게 List로 짓는 건 어떨까요?
tests/types_test.py
Outdated
| with raises(TypeError): | ||
| immutable_list + [3] | ||
|
|
||
| assert isinstance(immutable_list, collections.Sequence) |
There was a problem hiding this comment.
사소하지만 collections.MutableSequence가 아닌지도 검사하면 좋을 듯하네요.
d563815 to
ee413c4
Compare
ee413c4 to
a1ab6f5
Compare
|
@dahlia changelog 도 쓰고 리뷰해주셨던거 반영했습니다. |
dahlia
approved these changes
Mar 20, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
collections.Sequence를 구현하는nirum.datastructures.List를 구현합니다.