8000 Fix template file spacing for `ssl_protocols` directive by j1m-ryan · Pull Request #5020 · nginx/kubernetes-ingress · GitHub
[go: up one dir, main page]
Skip to content

Fix template file spacing for ssl_protocols directive #5020

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 1, 2024
Merged

Fix template file spacing for ssl_protocols directive #5020

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d7c2bb4
template file space
Jan 31, 2024
5ccbfbb
Merge branch 'main' into fix/template-file-ssl-protocol
Jan 31, 2024
9aeb786
Merge branch 'main' into fix/template-file-ssl-protocol
Feb 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 12 additions & 4 deletions internal/configs/version1/nginx-plus.tmpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,10 +130,18 @@ http {
default upgrade;
'' $default_connection_header;
}
{{- if .SSLProtocols}}ssl_protocols {{.SSLProtocols}};{{end}}
{{- if .SSLCiphers}}ssl_ciphers "{{.SSLCiphers}}";{{end}}
{{- if .SSLPreferServerCiphers}}ssl_prefer_server_ciphers on;{{end}}
{{- if .SSLDHParam}}ssl_dhparam {{.SSLDHParam}};{{end}}
{{- if .SSLProtocols}}
ssl_protocols {{.SSLProtocols}};
{{- end}}
{{- if .SSLCiphers}}
ssl_ciphers "{{.SSLCiphers}}";
{{- end}}
{{- if .SSLPreferServerCiphers}}
ssl_prefer_server_ciphers on;
{{- end}}
{{- if .SSLDHParam}}
ssl_dhparam {{.SSLDHParam}};
{{- end}}

{{- if .OpenTracingEnabled}}
opentracing on;
Expand Down
16 changes: 12 additions & 4 deletions internal/configs/version1/nginx.tmpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,10 +91,18 @@ http {
default upgrade;
'' $default_connection_header;
}
{{- if .SSLProtocols}}ssl_protocols {{.SSLProtocols}};{{end}}
{{- if .SSLCiphers}}ssl_ciphers "{{.SSLCiphers}}";{{end}}
{{- if .SSLPreferServerCiphers}}ssl_prefer_server_ciphers on;{{end}}
{{- if .SSLDHParam}}ssl_dhparam {{.SSLDHParam}};{{end}}
{{- if .SSLProtocols}}
ssl_protocols {{.SSLProtocols}};
{{- end}}
{{- if .SSLCiphers}}
ssl_ciphers "{{.SSLCiphers}}";
{{- end}}
{{- if .SSLPreferServerCiphers}}
ssl_prefer_server_ciphers on;
{{- end}}
{{- if .SSLDHParam}}
ssl_dhparam {{.SSLDHParam}};
{{- end}}

{{- if .OpenTracingEnabled}}
opentracing on;
Expand Down
0