E533 Fix template file spacing for `ssl_protocols` directive by j1m-ryan · Pull Request #5020 · nginx/kubernetes-ingress · GitHub
[go: up one dir, main page]
Skip to content

Fix template file spacing for ssl_protocols directive #5020

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 1, 2024
Merged

Fix template file spacing for ssl_protocols directive #5020

merged 3 commits into from
Feb 1, 2024

Conversation

j1m-ryan
Copy link

Proposed changes

Before

map $http_upgrade $vs_connection_header {
        default upgrade;
        ''      $default_connection_header;
}ssl_protocols TLSv1.2 TLSv1.3;

After

map $http_upgrade $vs_connection_header {
        default upgrade;
        ''      $default_connection_header;
}
ssl_protocols TLSv1.2 TLSv1.3;

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@j1m-ryan j1m-ryan requested a review from a team as a code owner January 31, 2024 17:32
@netlify Netlify
Copy link
netlify bot commented Jan 31, 2024 •
edited
Loading

👷 Deploy request for nginx-kubernetes-ingress pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit 9aeb786

@github-actions github-actions bot added the bug An issue reporting a potential bug label Jan 31, 2024
@codecov Codecov
Copy link
codecov bot commented Jan 31, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (81a2233) 52.32% compared to head (5ccbfbb) 52.35%.
Report is 3 commits behind head on main.

❗ Current head 5ccbfbb differs from pull request most recent head 9aeb786. Consider uploadin 7440 g reports for the commit 9aeb786 to get more accurate results

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #5020      +/-   ##
==========================================
+ Coverage   52.32%   52.35%   +0.03%     
==========================================
  Files          61       61              
  Lines       17502    17502              
==========================================
+ Hits         9158     9164       +6     
+ Misses       8015     8011       -4     
+ Partials      329      327       -2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@j1m-ryan j1m-ryan enabled auto-merge (squash) February 1, 2024 09:12
@j1m-ryan j1m-ryan merged commit 7f0efa4 into nginx:main Feb 1, 2024
@jasonwilliams14 jasonwilliams14 mentioned this pull request Feb 8, 2024
Closed
j1m-ryan pushed a commit to j1m-ryan/kubernetes-ingress that referenced this pull request Feb 9, 2024
Fix template file spacing for ssl_protocols directive (nginx#5020)
57e9cf2 
template file space
j1m-ryan pushed a commit to j1m-ryan/kubernetes-ingress that referenced this pull request Feb 9, 2024
Fix template file spacing for ssl_protocols directive (nginx#5020)
1cd0df1 
template file space
j1m-ryan pushed a commit that referenced this pull request Feb 9, 2024
cherry pick: Fix template file spacing for ssl_protocols directive (#…
203cb6e 
…5020) (#5060)

Fix template file spacing for `ssl_protocols` directive (#5020)

template file space
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vepatel vepatel vepatel approved these changes

@pdabelf5 pdabelf5 pdabelf5 approved these changes

+1 more reviewer

@oseoin oseoin oseoin approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
bug An issue reporting a potential bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@j1m-ryan @oseoin @vepatel @pdabelf5
0